Issue 4613 - fix leak of Thread

src/WebRequestJsObject.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 12 matching lines @@
 #include "Thread.h"
 #include "Utils.h"
 #include "WebRequestJsObject.h"
 
 namespace
 {
   class WebRequestThread : public AdblockPlus::Thread
   {
   public:
     WebRequestThread(AdblockPlus::JsEnginePtr jsEngine, AdblockPlus::JsValueList& arguments)
-        : jsEngine(jsEngine), url(arguments[0]->AsString())
+        : Thread(true), jsEngine(jsEngine), url(arguments[0]->AsString())
     {
       if (!url.length())
         throw std::runtime_error("Invalid string passed as first argument to GET");
 
       {
         AdblockPlus::JsValuePtr headersObj = arguments[1];
         if (!headersObj->IsObject())
           throw std::runtime_error("Second argument to GET must be an object");
 
         std::vector<std::string> properties = headersObj->GetOwnPropertyNames();
@@ skipping 27 matching lines @@
       for (AdblockPlus::HeaderList::iterator it = result.responseHeaders.begin();
         it != result.responseHeaders.end(); ++it)
       {
         headersObject->SetProperty(it->first, it->second);
       }
       resultObject->SetProperty("responseHeaders", headersObject);
 
       AdblockPlus::JsValueList params;
       params.push_back(resultObject);
       callback->Call(params);
-      delete this;
     }
 
   private:
     AdblockPlus::JsEnginePtr jsEngine;
     std::string url;
     AdblockPlus::HeaderList headers;
     AdblockPlus::JsValuePtr callback;
   };
 
   v8::Handle<v8::Value> GETCallback(const v8::Arguments& arguments)
@@ skipping 17 matching lines @@
     return v8::Undefined();
   }
 }
 
 AdblockPlus::JsValuePtr AdblockPlus::WebRequestJsObject::Setup(
     AdblockPlus::JsEnginePtr jsEngine, AdblockPlus::JsValuePtr obj)
 {
   obj->SetProperty("GET", jsEngine->NewCallback(::GETCallback));
   return obj;
 }