test/content.html - Issue 29361647: Issue 4607 - Default content styles

Side by Side Diff: test/content.html

Issue 29361647: Issue 4607 - Default content styles (Closed)

Patch Set: See comments for details. Created Nov. 27, 2016, 9:26 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <!--

	3 This file is part of website-defaults

	4 Copyright (C) 2016 Eyeo GmbH

	5

	6 website-defaults is free software: you can redistribute it and/or

	7 modify it under the terms of the GNU General Public License as published by

	8 the Free Software Foundation, either version 3 of the License, or

	9 (at your option) any later version.

	10

	11 website-defaults is distributed in the hope that it will be useful,

	12 but WITHOUT ANY WARRANTY; without even the implied warranty of

	13 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

	14 GNU General Public License for more details.

	15

	16 You should have received a copy of the GNU General Public License

	17 along with website-defaults. If not, see <http://www.gnu.org/licenses/>.

	18 -->

	19 <html dir="ltr">

	20 <head>

	21 <meta charset="utf-8">

	22 <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to- fit=no">

	23 <meta http-equiv="x-ua-compatible" content="ie=edge">

	24 <title>Content</title>

	25 <link rel="stylesheet" href="css/main.css">

	26 <link rel="stylesheet" href="css/demo.css">
	juliandoucette 2016/11/27 21:45:39 Note. Moved inline styles into test/css/demo.css Note. Moved inline styles into test/css/demo.css
	27 </head>

	28 <body>

	29 <div class="container">

	30

	31 <h1>Content</h1>

	32 <p>Default styles for a subset of HTML5 elements that are supported by Markd own and recommended for website content and styleguide coverage.</p>
	juliandoucette 2016/11/27 21:45:38 Note. Updated the description and added requireme Note. Updated the description and added requirements with dumb deeplinks.
	33

	34 <h2>Requirements</h2>
	saroyanm 2016/11/29 17:51:08 Detail: It's table of content not requirements. Detail: It's table of content not requirements. juliandoucette 2016/11/29 20:41:22 This was intended to be a high level list of requi Show quoted text On 2016/11/29 17:51:08, saroyanm wrote: > Detail: It's table of content not requirements. This was intended to be a high level list of requirements that also link to implementations. juliandoucette 2016/11/30 18:26:01 Acknowledged We're going to remove this heading, Show quoted text On 2016/11/29 20:41:22, juliandoucette wrote: > On 2016/11/29 17:51:08, saroyanm wrote: > > Detail: It's table of content not requirements. > > This was intended to be a high level list of requirements that also link to > implementations. Acknowledged We're going to remove this heading, rtl, and browser support items from this demo. juliandoucette 2016/12/01 14:05:46 Done. Show quoted text On 2016/11/30 18:26:01, juliandoucette wrote: > On 2016/11/29 20:41:22, juliandoucette wrote: > > On 2016/11/29 17:51:08, saroyanm wrote: > > > Detail: It's table of content not requirements. > > > > This was intended to be a high level list of requirements that also link to > > implementations. > > Acknowledged > > We're going to remove this heading, rtl, and browser support items from this > demo. Done.
	35 <ul>

	36 <li><a href="#headings">Headings</a></li>

	37 <li><a href="#body-content">Body content</a></li>

	38 <li><a href="#lists">Lists</a></li>

	39 <li><a href="#images">Images</a></li>

	40 <li><a id="dir" onclick="changeDirection()">Right-to-left</a></li>
	juliandoucette 2016/11/27 21:45:40 Note. onclick is officially supported in HTML5. Note. onclick is officially supported in HTML5. (I didn't know.) saroyanm 2016/11/29 17:51:07 Not really sure what you mean, Event attributes ar Show quoted text On 2016/11/27 21:45:40, juliandoucette wrote: > Note. > > onclick is officially supported in HTML5. > > (I didn't know.) Not really sure what you mean, Event attributes are discouraged to be used: https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Event_attributes#Exam... juliandoucette 2016/11/29 20:41:21 Acknowledged. I meant that I think this is a good Show quoted text On 2016/11/29 17:51:07, saroyanm wrote: > On 2016/11/27 21:45:40, juliandoucette wrote: > > Note. > > > > onclick is officially supported in HTML5. > > > > (I didn't know.) > > Not really sure what you mean, Event attributes are discouraged to be used: > https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Event_attributes#Exam... Acknowledged. I meant that I think this is a good use case for event attributes, which are now standard in HTML5. My choice was: 1. Use event attributes, getElementById, and innerHTML OR 2. Polyfill addEventListener, DOMContentLoaded, querySelectorAll, and innerText (via ie8.js) -- to support IE 8. I guess we will have to include ie8.js later for other components anyway. So I will change this. juliandoucette 2016/11/30 18:26:02 Acknowledged. This was made irrelevant because of Show quoted text On 2016/11/29 20:41:21, juliandoucette wrote: > On 2016/11/29 17:51:07, saroyanm wrote: > > On 2016/11/27 21:45:40, juliandoucette wrote: > > > Note. > > > > > > onclick is officially supported in HTML5. > > > > > > (I didn't know.) > > > > Not really sure what you mean, Event attributes are discouraged to be used: > > > https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Event_attributes#Exam... > > Acknowledged. > > I meant that I think this is a good use case for event attributes, which are now > standard in HTML5. > > My choice was: > > 1. Use event attributes, getElementById, and innerHTML > > OR > > 2. Polyfill addEventListener, DOMContentLoaded, querySelectorAll, and innerText > (via ie8.js) > > -- to support IE 8. > > I guess we will have to include ie8.js later for other components anyway. So I > will change this. Acknowledged. This was made irrelevant because of the previous comment (About table of contents). juliandoucette 2016/12/01 14:05:47 Done. Show quoted text On 2016/11/30 18:26:02, juliandoucette wrote: > On 2016/11/29 20:41:21, juliandoucette wrote: > > On 2016/11/29 17:51:07, saroyanm wrote: > > > On 2016/11/27 21:45:40, juliandoucette wrote: > > > > Note. > > > > > > > > onclick is officially supported in HTML5. > > > > > > > > (I didn't know.) > > > > > > Not really sure what you mean, Event attributes are discouraged to be used: > > > > > > https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Event_attributes#Exam... > > > > Acknowledged. > > > > I meant that I think this is a good use case for event attributes, which are > now > > standard in HTML5. > > > > My choice was: > > > > 1. Use event attributes, getElementById, and innerHTML > > > > OR > > > > 2. Polyfill addEventListener, DOMContentLoaded, querySelectorAll, and > innerText > > (via ie8.js) > > > > -- to support IE 8. > > > > I guess we will have to include ie8.js later for other components anyway. So I > > will change this. > > Acknowledged. > > This was made irrelevant because of the previous comment (About table of > contents). Done.
	41 <li><a href="http://browserl.ist/?q=last+2+versions%2C+Safari+6%2C+IE+8">L ast 2 versions, Safari 6, IE 8</a></li>
	saroyanm 2016/11/29 17:51:08 What about linking to -> https://adblockplus.org/r What about linking to -> https://adblockplus.org/requirements "last 2 versions" doesn't include dev builds of browsers. juliandoucette 2016/11/29 20:44:05 Acknowledged. I think we should define our own re Show quoted text On 2016/11/29 17:51:08, saroyanm wrote: > What about linking to -> https://adblockplus.org/requirements > "last 2 versions" doesn't include dev builds of browsers. Acknowledged. I think we should define our own requirements. It would be a huge waste of resources to ask QA to test against the last 3 dev versions, Yandex, SeaMonkey, and Thunderbird. Regarding "last 2 versions, Safari 6, IE 8": - We may want to support more than ABP (EG: Android browser?) - We could match ABP requirements better How about: "> 1%, last 2 Firefox versions, last 2 Chrome versions, last 2 Opera versions, last 2 FirefoxAndroid versions, Safari >= 6, IE >= 6" http://browserl.ist/?q=%3E+1%25%2C+last+2+Firefox+versions%2C+last+2+Chrome+v... Could you weigh in here @Philip? juliandoucette 2016/11/29 20:46:41 I meant IE >= 8. Sorry guys :D. Show quoted text > "> 1%, last 2 Firefox versions, last 2 Chrome versions, last 2 Opera versions, > last 2 FirefoxAndroid versions, Safari >= 6, IE >= 6" > > http://browserl.ist/?q=%3E+1%25%2C+last+2+Firefox+versions%2C+last+2+Chrome+v... I meant IE >= 8. Sorry guys :D. juliandoucette 2016/11/30 18:26:01 Acknowledged. We will discuss this separately. Show quoted text On 2016/11/29 20:46:41, juliandoucette wrote: > > > "> 1%, last 2 Firefox versions, last 2 Chrome versions, last 2 Opera versions, > > last 2 FirefoxAndroid versions, Safari >= 6, IE >= 6" > > > > > http://browserl.ist/?q=%3E+1%25%2C+last+2+Firefox+versions%2C+last+2+Chrome+v... > > I meant IE >= 8. Sorry guys :D. Acknowledged. We will discuss this separately. juliandoucette 2016/12/01 14:05:46 Done. Show quoted text On 2016/11/30 18:26:01, juliandoucette wrote: > On 2016/11/29 20:46:41, juliandoucette wrote: > > > > > "> 1%, last 2 Firefox versions, last 2 Chrome versions, last 2 Opera > versions, > > > last 2 FirefoxAndroid versions, Safari >= 6, IE >= 6" > > > > > > > > > http://browserl.ist/?q=%3E+1%25%2C+last+2+Firefox+versions%2C+last+2+Chrome+v... > > > > I meant IE >= 8. Sorry guys :D. > > Acknowledged. > > We will discuss this separately. Done.
	42 </ul>

	43

	44 <h3 id="headings">Headings</h3>

	45 <h1>Heading 1</h1>

	46 <h2>Heading 2</h2>

	47 <h3>Heading 3</h3>

	48 <h4>Heading 4</h4>

	49 <h5>Heading 5</h5>

	50 <h6>Heading 6</h6>

	51

	52 <h3 id="body-content">Body content</h3>

	53 <p>This is a normal.</p>

	54 <p>This is <em>emphasized</em>.</p>

	55 <p>This is <strong>strong</strong>.</p>

	56 <p>This is an <abbr title="Abbreviation">abbr</abbr>.</p>

	57 <p>This is a <a href="#">link</a>.</p>

	58 <p>This has a footnote. <sup><a href="#" class="footnote-ref">1</a></sup></p >

	59 <blockquote>This is a blockquote.</blockquote>

	60

	61 <h3 id="lists">Lists</h3>

	62

	63 <h4>Ordered lists</h4>

	64 <ol>

	65 <li>This is a list item</li>

	66 <li>This is a list item

	67 <ol>

	68 <li>This is a list item</li>

	69 <li>This is a list item</li>

	70 </ol>

	71 </li>

	72 <li>This is a list item</li>

	73 </ol>

	74

	75 <h4>Unordered lists</h4>

	76 <ul>

	77 <li>This is a list item</li>

	78 <li>This is a list item

	79 <ul>

	80 <li>This is a list item</li>

	81 <li>This is a list item</li>

	82 </ul>

	83 </li>

	84 <li>This is a list item</li>

	85 </ul>

	86

	87 <h4>Description lists</h4>

	88 <dl>

	89 <dt>This is a description title</dt>

	90 <dd>This is a description detail</dd>

	91 <dt>This is a description title</dt>

	92 <dd>This is a description detail</dd>

	93 </dl>

	94

	95 <h3 id="images">Images</h3>

	96 <p>
	juliandoucette 2016/11/27 21:45:39 Note. Images are always surrounded by paragraphs Note. Images are always surrounded by paragraphs when converted from markdown unless they appear in the middle of text. As a result, we can rely on top and bottom margins via paragraph within content.
	97 <img src="//placehold.it/480x240?text=Fixed width" />

	98 </p>

	99 <p>

	100 <img class="full-width" src="//placehold.it/960x240?text=Full width" />

	101 </p>

	102

	103 </div>

	104 <script src="js/demo.js"></script>
	juliandoucette 2016/11/27 21:45:38 Note. Created test/js/demo.js for switching the d Note. Created test/js/demo.js for switching the direction via the link in requirements. juliandoucette 2016/11/30 18:26:02 Acknowledged. This will be removed. Show quoted text On 2016/11/27 21:45:38, juliandoucette wrote: > Note. > > Created test/js/demo.js for switching the direction via the link in > requirements. Acknowledged. This will be removed. juliandoucette 2016/12/01 14:05:45 Done. Show quoted text On 2016/11/30 18:26:02, juliandoucette wrote: > On 2016/11/27 21:45:38, juliandoucette wrote: > > Note. > > > > Created test/js/demo.js for switching the direction via the link in > > requirements. > > Acknowledged. > > This will be removed. Done.
	105 </body>

	106 </html>

OLD	NEW

« scss/_variables.scss ('K') | « scss/main.scss ('k') | test/css/demo.css » ('j') | test/index.html » ('J')