README.md - Issue 29361647: Issue 4607 - Default content styles

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: README.md

Issue 29361647: Issue 4607 - Default content styles (Closed)

Left Patch Set: Removed missing grid dependency. Created Nov. 3, 2016, 5:48 p.m.

Right Patch Set: See comments for details Created Dec. 1, 2016, 2:05 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 # Universal Design Language	1 # Website defaults

2	2

3 Universal styles for Eyeo websites	3 Sensible defaults for Eyeo websites.

	4

	5 ## Dependencies

	6

	7 - [nodejs](https://nodejs.org/)

	8 - [gulp-cli](http://gulpjs.com/) `npm install --global gulp-cli`

4	9

5 ## Usage	10 ## Usage
saroyanm 2016/11/03 19:41:13 I think "usage" section doesn't belong to current I think "usage" section doesn't belong to current review. saroyanm 2016/11/03 19:41:13 Please add the build process to the Readme file if Please add the build process to the Readme file if you think it doesn't belongs here, make sense to add it to the review description. juliandoucette 2016/11/03 22:59:37 Why? Show quoted text On 2016/11/03 19:41:13, saroyanm wrote: > I think "usage" section doesn't belong to current review. Why? juliandoucette 2016/11/03 22:59:37 Acknowledged. Sorry about the confusion. Show quoted text On 2016/11/03 19:41:13, saroyanm wrote: > Please add the build process to the Readme file if you think it doesn't belongs > here, make sense to add it to the review description. Acknowledged. Sorry about the confusion. saroyanm 2016/11/04 16:01:17 Maybe because I don't understand how to use it :D Show quoted text On 2016/11/03 22:59:37, juliandoucette wrote: > On 2016/11/03 19:41:13, saroyanm wrote: > > I think "usage" section doesn't belong to current review. > > Why? Maybe because I don't understand how to use it :D I'll need to review the package and gulp first I assume. I'll return to this commit, sorry for confusion. juliandoucette 2016/11/04 17:32:25 We'll leave out usage and features and add install Show quoted text On 2016/11/04 16:01:17, saroyanm wrote: > On 2016/11/03 22:59:37, juliandoucette wrote: > > On 2016/11/03 19:41:13, saroyanm wrote: > > > I think "usage" section doesn't belong to current review. > > > > Why? > > Maybe because I don't understand how to use it :D > I'll need to review the package and gulp first I assume. > I'll return to this commit, sorry for confusion. We'll leave out usage and features and add install instructions. juliandoucette 2016/11/08 15:51:57 Done. Show quoted text On 2016/11/04 17:32:25, juliandoucette wrote: > On 2016/11/04 16:01:17, saroyanm wrote: > > On 2016/11/03 22:59:37, juliandoucette wrote: > > > On 2016/11/03 19:41:13, saroyanm wrote: > > > > I think "usage" section doesn't belong to current review. > > > > > > Why? > > > > Maybe because I don't understand how to use it :D > > I'll need to review the package and gulp first I assume. > > I'll return to this commit, sorry for confusion. > > We'll leave out usage and features and add install instructions. Done.
6	11

7 1. `npm i eyeo_gmbh/universal-design-lanugage --save`	12 ### Development

8 2. `@import "../../node_modules/universal-design-language/scss/main"`

9 3. Profit

10	13

11 ## Features	14 - Install local dependencies `npm install`

12	15 - Run build proceedure `gulp`

13 1. CSS reset (extends normalize.css)	16 - Browse `http://localhost:8080/`

14 2. Standard HTML + Markdown content styles

LEFT	RIGHT