Issue 4644 - Pass search messages to our devtools panel

chrome/devtools.js

Index: chrome/devtools.js
diff --git a/chrome/devtools.js b/chrome/devtools.js
index 255aeb387bfa8db9e15005390587874a782f4a1b..aed487c1fdef1c8ae00dd1cf9306e836fe5f50c4 100644
--- a/chrome/devtools.js
+++ b/chrome/devtools.js
@@ -17,6 +17,8 @@
 
 "use strict";
 
+var panelWindow = null;

[Sebastian Noack, 2017/01/12 23:25:02]

Is the panel (and it's window) a singleton? What if you use the developer tools
panel on multiple pages simultaneously?

[Sebastian Noack, 2017/01/12 23:25:02]

Any reason to not use let (instead of var) here?

[kzar, 2017/01/13 08:30:08]

Done.

[kzar, 2017/01/13 08:30:08]

Good point, but I just tested and it works fine with multiple windows. I think
devtools.js is run in it's own context for each developer tools window.

+
 chrome.runtime.sendMessage(
   {
     type: "prefs.get",
@@ -25,8 +27,35 @@ chrome.runtime.sendMessage(
   function(enabled)
   {
     if (enabled)
-      chrome.devtools.panels.create("Adblock Plus",
-                                    "icons/detailed/abp-48.png",
-                                    "devtools-panel.html");
+    {
+      chrome.devtools.panels.create(
+        "Adblock Plus",
+        "icons/detailed/abp-48.png",
+        "devtools-panel.html",
+        function (panel)

[Sebastian Noack, 2017/01/12 23:25:02]

I wonder whether we should use arrow functions here? Also I wonder what the rule
for using arrow functions in general should be? It seems in recent code (that
you wrote or reviewed) we use arrow functions for all anonymous function unless
we explicitly need no implicit binding.

[kzar, 2017/01/13 08:30:08]

I think the rule is to use let and arrow functions wherever possible now. I
should really get around to updating the existing code too, I'll try and open a
review for that today.

[Sebastian Noack, 2017/01/13 11:57:38]

I tend to agree. Mind filing a review to add it to
https://adblockplus.org/coding-style#javascript ?

+        {
+          panel.onShown.addListener(function(window)
+          {
+            panelWindow = window;
+          });
+
+          panel.onHidden.addListener(function(window)
+          {
+            panelWindow = null;
+          });
+
+          panel.onSearch.addListener(function(eventName, queryString)
+          {
+            if (panelWindow)
+            {
+              panelWindow.postMessage({
+                type: eventName,
+                queryString: queryString
+              }, "*");
+            }
+          });
+        }
+      );
+    }
   }
 );