Issue 2313 - Handle Flup dependency in module sitescripts

modules/sitescripts/manifests/init.pp

 class sitescripts (
     $sitescriptsini_source = '',
     $sitescriptsini_content = '',
   ){
 
   @concat {'/etc/sitescripts.ini':
     mode => 644,
     owner => root,
     group => root,
   }
 
   define configfragment($content = '', $source = '') {
 
     realize(Concat['/etc/sitescripts.ini'])
 
     concat::fragment {"/etc/sitescripts.ini#$title":
       target  => '/etc/sitescripts.ini',
       content => $content,
       source  => "$source$content" ? {
         ''     => $title,
         default => $source,
       }
     }
   }
 
-  package {'python-flup':}

[mathias, 2016/11/18 10:59:03]

Please always use ensure_packages from stdlib when there are no specific options
for the package resource.

-
+  ensure_packages(['python-flup'])
+  
   if ($sitescriptsini_source != '') or ($sitescriptsini_content != '') {
 
     $content = $sitescriptsini_content
     $source = $sitescriptsini_source
   }
   else {
 
     $content = "# Puppet: Class['$title']\n"
     $source = ''
   }
@@ skipping 14 matching lines @@
   }
 
   cron {"update_sitescripts":
     ensure => present,
     command => "hg pull -q -u -R /opt/sitescripts && /opt/sitescripts/ensure_dependencies.py -q",
     environment => hiera('cron::environment', []),
     user => root,
     require => Exec["fetch_sitescripts"],
   }
 }