Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: lib/prefs.js

Issue 29363607: Issue 4612 - enable AA on first run and make automatic adding of any subscription optional (Closed)
Patch Set: address comments Created Nov. 22, 2016, 12:22 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 26 matching lines...) Expand all
37 update_url_devbuild: "https://adblockplus.org/devbuilds/%NAME%/update.json?typ e=%TYPE%", 37 update_url_devbuild: "https://adblockplus.org/devbuilds/%NAME%/update.json?typ e=%TYPE%",
38 update_last_check: 0, 38 update_last_check: 0,
39 update_last_error: 0, 39 update_last_error: 0,
40 update_soft_expiration: 0, 40 update_soft_expiration: 0,
41 update_hard_expiration: 0, 41 update_hard_expiration: 0,
42 currentVersion: "0.0", 42 currentVersion: "0.0",
43 notificationdata: {}, 43 notificationdata: {},
44 notificationurl: "https://notification.adblockplus.org/notification.json", 44 notificationurl: "https://notification.adblockplus.org/notification.json",
45 suppress_first_run_page: false, 45 suppress_first_run_page: false,
46 disable_auto_updates: false, 46 disable_auto_updates: false,
47 first_run_subscription_auto_select: true,
47 notifications_ignoredcategories: [], 48 notifications_ignoredcategories: [],
48 }; 49 };
49 50
50 let preconfigurable = ["suppress_first_run_page", "disable_auto_updates"]; 51 let preconfigurable = ["suppress_first_run_page", "disable_auto_updates",
52 "first_run_subscription_auto_select"];
51 53
52 let values; 54 let values;
53 let path = _fileSystem.resolve("prefs.json"); 55 let path = _fileSystem.resolve("prefs.json");
54 let listeners = []; 56 let listeners = [];
55 let isDirty = false; 57 let isDirty = false;
56 let isSaving = false; 58 let isSaving = false;
57 59
58 function defineProperty(key) 60 function defineProperty(key)
59 { 61 {
60 Object.defineProperty(Prefs, key, 62 Object.defineProperty(Prefs, key,
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 defaults[key] = _preconfiguredPrefs[key]; 144 defaults[key] = _preconfiguredPrefs[key];
143 145
144 // Define defaults 146 // Define defaults
145 for (let key in defaults) 147 for (let key in defaults)
146 defineProperty(key); 148 defineProperty(key);
147 149
148 // Set values of prefs based on defaults 150 // Set values of prefs based on defaults
149 values = Object.create(defaults); 151 values = Object.create(defaults);
150 152
151 load(); 153 load();
OLDNEW

Powered by Google App Engine
This is Rietveld