Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: mozconfig-arm
Issue
29365816
:
Issue 4677 - Add support for x86 builds in adblockbrowser-build (Closed)
Patch Set: Not changing previous exit codes per Anton's suggestion
Created Dec. 1, 2016, 1:59 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Not changing previous exit codes per Anton's suggestion
Patch Set 3: Adding missing MOZILLA_OFFICIAL config
Right:
Patch Set 1: None
Patch Set 2: Not changing previous exit codes per Anton's suggestion
Patch Set 3: Adding missing MOZILLA_OFFICIAL config
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
.hgignore
adblockbrowser-cfg.py
build.py
config.py.sample
mozconfig-arm
mozconfig-common
mozconfig-custom
mozconfig-release
mozconfig-standalone-devbuild
mozconfig-standalone-release
mozconfig-store
mozconfig-store-devbuild
mozconfig-store-release
mozconfig-x86
View unified diff
|
Download patch
« no previous file with comments
|
« config.py.sample
('k') |
mozconfig-common »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
# Do not modify this file. If you want to add custom configuration, use the mozc onfig-custom file instead.
2
ac_add_options --target=arm-linux-androideabi
OLD
NEW
« no previous file with comments
|
« config.py.sample
('k') |
mozconfig-common »
('j') |
no next file with comments »
Edit Message
Issue 29365816: Issue 4677 - Add support for x86 builds in adblockbrowser-build (Closed)
Created Nov. 30, 2016, 2:23 p.m. by diegocarloslima
Modified Dec. 28, 2016, 6:31 p.m.
Reviewers: anton, Felix Dahlke
Base URL:
Comments: 4
This is Rietveld