Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: README.md

Issue 29365879: Issue 4616 - Push Edge related changes to the edge bookmark of adblockpluschrome (Closed)
Patch Set: Adapt the README.md Created Dec. 19, 2016, 11:42 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | icons/abp-150.png » ('j') | metadata.edge » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: README.md
===================================================================
--- a/README.md
+++ b/README.md
@@ -1,9 +1,9 @@
-Adblock Plus for Chrome and Opera
-=================================
+Adblock Plus for Chrome and Opera and Edge
kzar 2016/12/19 13:34:17 Nit: Second "and" should be a comma.
Oleksandr 2016/12/19 14:12:13 Done.
+==========================================
This repository contains the platform-specific Adblock Plus source code for
-Chrome and Opera. It can be used to build Adblock Plus for these platforms,
-generic Adblock Plus code will be extracted from other repositories
+Chrome, Opera and Edge. It can be used to build Adblock Plus for these
+platforms, generic Adblock Plus code will be extracted from other repositories
automatically (see _dependencies_ file).
Building
@@ -19,26 +19,34 @@
### Building the extension
-Run the following command in the project directory:
+Run one of the following commands in the project directory, depending on your
+target platform:
./build.py -t chrome build -k adblockpluschrome.pem
+ ./build.py -t edge build
This will create a build with a name in the form
-_adblockpluschrome-1.2.3.nnnn.crx_
+_adblockpluschrome-1.2.3.nnnn.crx_ or adblockplusedge-1.2.3.nnnn.appx.
kzar 2016/12/19 13:34:17 Please surround the example edge filename with und
Oleksandr 2016/12/19 14:12:13 Done.
Note that you don't need an existing signing key for Chrome, a new key
will be created automatically if the file doesn't exist.
### Development environment
To simplify the process of testing your changes you can create an unpacked
-development environment. For that run the following command:
+development environment. For that run one of the following commands:
./build.py -t chrome devenv
+ ./build.py -t edge devenv
-This will create a _devenv.chrome_ directory in the repository. In Chrome you
-should load the directory as an unpacked extension. After making changes to the
-source code re-run the command to update the development environment, the
-extension should reload automatically after a few seconds.
+This will create a _devenv.platform_ directory in the repository. In Chrome you
+should load _devenv.chrome_ as an unpacked extension directory. After making
+changes to the source code re-run the command to update the development
+environment, the extension should reload automatically after a few seconds.
+
+For Edge you should load _devenv.edge/Extension_ as an unpacked extension
+directory. Edge build does not automatically detect changes, so after
+rebuilding the extension you should manually force reloading it in Edge by
+hitting the _Reload Extension_ button.
Running the unit tests
----------------------
« no previous file with comments | « no previous file | icons/abp-150.png » ('j') | metadata.edge » ('J')

Powered by Google App Engine
This is Rietveld