Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: lib/api.js

Issue 29366747: Issue 4657 - Add Acceptable Ads API (Closed)
Left Patch Set: address comments and rebase Created March 17, 2017, 3:49 p.m.
Right Patch Set: fix typo Created April 5, 2017, 4:53 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « include/AdblockPlus/FilterEngine.h ('k') | lib/compat.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 144
145 setAASubscriptionEnabled: function(enabled) 145 setAASubscriptionEnabled: function(enabled)
146 { 146 {
147 var aaSubscription = FilterStorage.subscriptions.find(API.isAASubscription ); 147 var aaSubscription = FilterStorage.subscriptions.find(API.isAASubscription );
148 if (!enabled) 148 if (!enabled)
149 { 149 {
150 if (aaSubscription && !aaSubscription.disabled) 150 if (aaSubscription && !aaSubscription.disabled)
151 aaSubscription.disabled = true; 151 aaSubscription.disabled = true;
152 return; 152 return;
153 } 153 }
154 if (!aaSubscription) { 154 if (!aaSubscription)
hub 2017/03/17 20:04:15 'nit: new line before the {
sergei 2017/03/17 22:10:06 Done.
155 {
155 aaSubscription = Subscription.fromURL(Prefs.subscriptions_exceptionsurl) ; 156 aaSubscription = Subscription.fromURL(Prefs.subscriptions_exceptionsurl) ;
156 FilterStorage.addSubscription(aaSubscription); 157 FilterStorage.addSubscription(aaSubscription);
157 } 158 }
158 if (aaSubscription.disabled) 159 if (aaSubscription.disabled)
159 aaSubscription.disabled = false; 160 aaSubscription.disabled = false;
160 if (!aaSubscription.lastDownload) 161 if (!aaSubscription.lastDownload)
161 Synchronizer.execute(aaSubscription); 162 Synchronizer.execute(aaSubscription);
162 }, 163 },
163 164
164 isAASubscriptionEnabled: function() 165 isAASubscriptionEnabled: function()
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 return Prefs[pref]; 200 return Prefs[pref];
200 }, 201 },
201 202
202 setPref: function(pref, value) 203 setPref: function(pref, value)
203 { 204 {
204 Prefs[pref] = value; 205 Prefs[pref] = value;
205 }, 206 },
206 207
207 forceUpdateCheck: function(eventName) 208 forceUpdateCheck: function(eventName)
208 { 209 {
209 checkForUpdates(_triggerEvent.bind(null, eventName)); 210 checkForUpdates(eventName ? _triggerEvent.bind(null, eventName) : null);
210 }, 211 },
211 212
212 getHostFromUrl: function(url) 213 getHostFromUrl: function(url)
213 { 214 {
214 return extractHostFromURL(url); 215 return extractHostFromURL(url);
215 }, 216 },
216 217
217 compareVersions: function(v1, v2) 218 compareVersions: function(v1, v2)
218 { 219 {
219 return Services.vc.compare(v1, v2); 220 return Services.vc.compare(v1, v2);
220 } 221 }
221 }; 222 };
222 })(); 223 })();
LEFTRIGHT

Powered by Google App Engine
This is Rietveld