tests/metadata.edge - Issue 29368690: [buildtools] Issue 4578 - Make uap3:AppExtension.Id configurable for Microsoft Edge builds

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: tests/metadata.edge

Issue 29368690: [buildtools] Issue 4578 - Make uap3:AppExtension.Id configurable for Microsoft Edge builds (Closed)

Left Patch Set: Fallback to EdgeExtension if no extension_id configured Created Jan. 9, 2017, 11:04 a.m.

Right Patch Set: Removed extension_id_devbuild option from test metadata Created Jan. 10, 2017, 8:08 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [general]	1 [general]

2 version = 1.2.3	2 version = 1.2.3

3 author = Eyeo GmbH	3 author = Eyeo GmbH

4 basename = adblockplusedge	4 basename = adblockplusedge

5 app_id = EyeoGmbH.AdblockPlus	5 app_id = EyeoGmbH.AdblockPlus

6 publisher_id = CN=4F066043-8AFE-41C9-B762-6C15E77E3F88	6 publisher_id = CN=4F066043-8AFE-41C9-B762-6C15E77E3F88

7 background_color = red	7 background_color = red

8 permissions = tabs	8 permissions = tabs

9 http:///	9 http:///

10 https:///	10 https:///

11 contextMenus	11 contextMenus

12 webRequest	12 webRequest

13 webRequestBlocking	13 webRequestBlocking

14 webNavigation	14 webNavigation

15 storage	15 storage

16 unlimitedStorage	16 unlimitedStorage

17 notifications	17 notifications

18 options = options.html	18 options = options.html

19 backgroundScripts = lib/info.js	19 backgroundScripts = lib/info.js

20 extension_id_release = 1.0	20 extension_id_release = 1.0

21 extension_id_devbuild = EdgeExtension
Sebastian Noack 2017/01/09 14:52:19 This seems redundant now, where we fallback to "Ed This seems redundant now, where we fallback to "EdgeExtension" as default. wspee 2017/01/10 08:09:00 Done. Show quoted text On 2017/01/09 14:52:19, Sebastian Noack wrote: > This seems redundant now, where we fallback to "EdgeExtension" as default. Done.
22	21

23 [appx_assets]	22 [appx_assets]

24 logo_44.png = chrome/icons/abp-44.png	23 logo_44.png = chrome/icons/abp-44.png

25 logo_50.png = chrome/icons/abp-50.png	24 logo_50.png = chrome/icons/abp-50.png

26 logo_150.png = chrome/icons/abp-150.png	25 logo_150.png = chrome/icons/abp-150.png

27	26

28 [mapping]	27 [mapping]

29 icons = chrome/icons	28 icons = chrome/icons

30	29

31 [compat]	30 [compat]

32 edge = 37.14332.1000.0	31 edge = 37.14332.1000.0

33 windows = 10.0.14332.0/12.0.0.0	32 windows = 10.0.14332.0/12.0.0.0

LEFT	RIGHT