[buildtools] Issue 4578 - Make uap3:AppExtension.Id configurable for Microsoft Edge builds

packagerEdge.py

Index: packagerEdge.py
diff --git a/packagerEdge.py b/packagerEdge.py
index f59d08bd585fc7304b4ff8908eeb4a93ae7c2beb..2f1a1b9b4edb2a12a80a33e3dd69cf966ec7cfba 100644
--- a/packagerEdge.py
+++ b/packagerEdge.py
@@ -85,6 +85,10 @@ def create_appx_manifest(params, files, release_build=False):
     params.update(metadata.items('general'))
     params['version'] = pad_version(params['version'])
 
+    metadata_id_suffix = 'release' if release_build else 'devbuild'
+    metadata_id = 'id_{}'.format(metadata_id_suffix)

[Sebastian Noack, 2017/01/07 10:18:46]

As per our coding style guide (https://adblockplus.org/coding-style#python) we
agreed to use the + operator when concatenating exactly two strings, while only
using the format() method for more complex string formatting. We think the code
is more readable that way.

Also I think the key should be "extension_id_*" rather than just "id_*", for
consistence and distinction from "app_id" and "publisher_id".

[wspee, 2017/01/09 09:15:52]

Done.

+    params['app_extension_id'] = metadata.get('general', metadata_id)
+
     translation = load_translation(files, defaultLocale)
     name_key = 'name' if release_build else 'name_devbuild'
     params['display_name'] = translation[name_key]['message']