Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: packagerEdge.py

Issue 29368690: [buildtools] Issue 4578 - Make uap3:AppExtension.Id configurable for Microsoft Edge builds (Closed)
Patch Set: Fallback to EdgeExtension if no extension_id configured Created Jan. 9, 2017, 11:04 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | templates/edge/AppxManifest.xml.tmpl » ('j') | tests/metadata.edge » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packagerEdge.py
diff --git a/packagerEdge.py b/packagerEdge.py
index f59d08bd585fc7304b4ff8908eeb4a93ae7c2beb..2d8ce5b62336edb1512f8a9ac10928c56b1708dd 100644
--- a/packagerEdge.py
+++ b/packagerEdge.py
@@ -85,6 +85,13 @@ def create_appx_manifest(params, files, release_build=False):
params.update(metadata.items('general'))
params['version'] = pad_version(params['version'])
+ metadata_id_suffix = 'release' if release_build else 'devbuild'
+ metadata_id = 'extension_id_' + metadata_id_suffix
+ if metadata.has_option('general', metadata_id):
+ params['app_extension_id'] = metadata.get('general', metadata_id)
+ else:
+ params['app_extension_id'] = 'EdgeExtension'
+
translation = load_translation(files, defaultLocale)
name_key = 'name' if release_build else 'name_devbuild'
params['display_name'] = translation[name_key]['message']
« no previous file with comments | « no previous file | templates/edge/AppxManifest.xml.tmpl » ('j') | tests/metadata.edge » ('J')

Powered by Google App Engine
This is Rietveld