packagerEdge.py - Issue 29368690: [buildtools] Issue 4578 - Make uap3:AppExtension.Id configurable for Microsoft Edge builds

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: packagerEdge.py

Issue 29368690: [buildtools] Issue 4578 - Make uap3:AppExtension.Id configurable for Microsoft Edge builds (Closed)

Patch Set: Removed extension_id_devbuild option from test metadata Created Jan. 10, 2017, 8:08 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: packagerEdge.py

diff --git a/packagerEdge.py b/packagerEdge.py

index f59d08bd585fc7304b4ff8908eeb4a93ae7c2beb..2d8ce5b62336edb1512f8a9ac10928c56b1708dd 100644

--- a/packagerEdge.py

+++ b/packagerEdge.py

@@ -85,6 +85,13 @@ def create_appx_manifest(params, files, release_build=False):

params.update(metadata.items('general'))

params['version'] = pad_version(params['version'])

+ metadata_id_suffix = 'release' if release_build else 'devbuild'

+ metadata_id = 'extension_id_' + metadata_id_suffix

+ if metadata.has_option('general', metadata_id):

+ params['app_extension_id'] = metadata.get('general', metadata_id)

+ else:

+ params['app_extension_id'] = 'EdgeExtension'

translation = load_translation(files, defaultLocale)

name_key = 'name' if release_build else 'name_devbuild'

params['display_name'] = translation[name_key]['message']

« no previous file with comments | « no previous file | templates/edge/AppxManifest.xml.tmpl » ('j') | no next file with comments »