[adblockpluscore] Issue 4762 - Added "relentless" notification that shows up in intervals

lib/notification.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 206 matching lines @@
         {
           if (typeof notification.interval == "number")
           {
             if (shown + notification.interval > Date.now())
               continue;
           }
           else if (shown)
             continue;
         }
 
-        if (Prefs.notifications_ignoredcategories.indexOf("*") != -1)
+        if (notification.type !== "relentless" && Prefs.notifications_ignoredcategories.indexOf("*") != -1)
           continue;
       }
 
       if (typeof url === "string" || notification.urlFilters instanceof Array)
       {
         if (Prefs.enabled && typeof url === "string" && notification.urlFilters instanceof Array)
         {
           let host;
           try
           {
@@ skipping 61 matching lines @@
    * @param {String} id ID of the notification to be marked as shown
    */
   markAsShown: function(id)
   {
     let now = Date.now();
     let data = Prefs.notificationdata;
 
     if (data.shown instanceof Array)
     {
       let newShown = {};
-      for (let old_id of data.shown)
-        newShown[old_id] = now;
+      for (let oldId of data.shown)
+        newShown[oldId] = now;
       data.shown = newShown;
     }
 
-    if (!(typeof data.shown == "object"))

[Sebastian Noack, 2017/01/06 14:17:02]

How about |typeof != "object"|?

[wspee, 2017/01/06 14:35:54]

Done.

+    if (typeof data.shown != "object")
       data.shown = {};
 
     data.shown[id] = now;
 
     saveNotificationData();
   },
 
   /**
    * Localizes the texts of the supplied notification.
    * @param {Object} notification notification to translate
@@ skipping 94 matching lines @@
       Prefs.notifications_showui = true;
     }
     else if (index != -1 && forceValue !== true)
       categories.splice(index, 1);
 
     // HACK: JSON values aren't saved unless they are assigned a different object.
     Prefs.notifications_ignoredcategories = JSON.parse(JSON.stringify(categories));
   }
 };
 Notification.init();