[adblockplusui] Issue 4915 - Define ext for background pages in antiadblockInit.js

lib/antiadblockInit.js

Index: lib/antiadblockInit.js
diff --git a/lib/antiadblockInit.js b/lib/antiadblockInit.js
index ac9ef424ab902bf0c3c18a0e0771a6b840d7a429..5e4f1b014c645d0821b4bccef27f9d1d57b6d8d8 100644
--- a/lib/antiadblockInit.js
+++ b/lib/antiadblockInit.js
@@ -25,6 +25,12 @@ let {FilterNotifier} = require("filterNotifier");
 let {Subscription} = require("subscriptionClasses");
 let {Notification} = require("notification");
 
+let ext = (
+  typeof window != "undefined" && window.ext ?
+  window.ext :
+  require("ext_background")
+);

[Sebastian Noack, 2017/02/20 16:27:25]

For reference, if it wouldn't be for ESLint's non-undef rule, this could be as
simple as:

  let ext = typeof ext != "undefined" ? ext : require("ext_background");

But even without directly accessing global variables from other scripts, it can
still be a little simpler:

  let ext = typeof window != "undefined" &&
            window.ext || require("ext_background");

[wspee, 2017/03/01 14:53:38]

Done.

[Wladimir Palant, 2017/03/02 11:14:39]

That wouldn't work, ESLint isn't spoiling the fun here but rather preventing a
bug. ext refers to the local let variable here, not to the global one you would
be interested in.
No, not simpler but clearly more obfuscated.

+
 exports.initAntiAdblockNotification = function initAntiAdblockNotification()
 {
   let notification = {