Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: lib/devtools.js

Issue 29370970: [adblockpluschrome] Issue 3596 - Added support for CSS property filters to devtools panel (Closed)
Left Patch Set: Made first approach work "properly" Created Jan. 19, 2017, 4:08 p.m.
Right Patch Set: Addressed review comment Created Feb. 23, 2017, 2:23 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « include.preload.js ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 "use strict"; 18 "use strict";
19 19
20 let { 20 const {RegExpFilter,
21 RegExpFilter, 21 WhitelistFilter,
22 WhitelistFilter, 22 ElemHideFilter,
23 ElemHideFilter, 23 ElemHideEmulationFilter} = require("filterClasses");
24 ElemHideEmulationFilter 24
25 } = require("filterClasses"); 25 const {SpecialSubscription} = require("subscriptionClasses");
26 26 const {FilterStorage} = require("filterStorage");
27 let {SpecialSubscription} = require("subscriptionClasses"); 27 const {defaultMatcher} = require("matcher");
28 let {FilterStorage} = require("filterStorage"); 28 const {FilterNotifier} = require("filterNotifier");
29 let {defaultMatcher} = require("matcher"); 29 const {extractHostFromFrame} = require("url");
30 let {FilterNotifier} = require("filterNotifier"); 30 const {port} = require("messaging");
31 let {extractHostFromFrame} = require("url");
32 let {port} = require("messaging");
33 31
34 const nonRequestTypes = ["DOCUMENT", "ELEMHIDE", "GENERICBLOCK", "GENERICHIDE"]; 32 const nonRequestTypes = ["DOCUMENT", "ELEMHIDE", "GENERICBLOCK", "GENERICHIDE"];
35 33
36 // Mapping of inspected tabs to their devpanel page 34 // Mapping of inspected tabs to their devpanel page
37 // and recorded items. We can't use a PageMap here, 35 // and recorded items. We can't use a PageMap here,
38 // because data must persist after navigation/reload. 36 // because data must persist after navigation/reload.
39 let panels = Object.create(null); 37 let panels = Object.create(null);
40 38
41 function hasPanels() 39 function hasPanels()
42 { 40 {
(...skipping 341 matching lines...) Expand 10 before | Expand all | Expand 10 after
384 panels[inspectedTabId] = {port: port, records: []}; 382 panels[inspectedTabId] = {port: port, records: []};
385 }); 383 });
386 384
387 port.on("devtools.traceElemHide", (message, sender) => 385 port.on("devtools.traceElemHide", (message, sender) =>
388 { 386 {
389 logHiddenElements( 387 logHiddenElements(
390 sender.page, message.selectors, 388 sender.page, message.selectors,
391 extractHostFromFrame(sender.frame) 389 extractHostFromFrame(sender.frame)
392 ); 390 );
393 }); 391 });
LEFTRIGHT

Powered by Google App Engine
This is Rietveld