chrome/ext/content.js - Issue 29371763: Issue 4795 - Use modern JavaScript syntax

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: chrome/ext/content.js

Issue 29371763: Issue 4795 - Use modern JavaScript syntax (Closed)

Patch Set: Created Jan. 13, 2017, 12:11 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: chrome/ext/content.js

diff --git a/chrome/ext/content.js b/chrome/ext/content.js

index b54fdcfb0c9f568738704a7587554dfce14949d8..62bf29290c515f09e848a2a4a911a07e5f091e89 100644

--- a/chrome/ext/content.js

+++ b/chrome/ext/content.js

@@ -1,14 +1,14 @@

-chrome.runtime.onMessage.addListener(function(message, sender, sendResponse)

+chrome.runtime.onMessage.addListener((message, sender, sendResponse) =>

{

return ext.onMessage._dispatch(message, {}, sendResponse).indexOf(true) != -1;

});

-ext.onExtensionUnloaded = (function()

+ext.onExtensionUnloaded = (() =>

{

- var port = null;

+ let port = null;

return {

- addListener: function(listener)

+ addListener: listener =>

{

if (!port)

port = chrome.runtime.connect();

@@ -17,7 +17,7 @@ ext.onExtensionUnloaded = (function()

// background page dies and automatically disconnects all ports

port.onDisconnect.addListener(listener);

- removeListener: function(listener)

+ removeListener: listener =>

{

if (port)

{