Issue 4813 - UTFDataFormatException while serializing filter

src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 418 matching lines @@
       if (this.filters == null)
       {
         filtersOut.writeInt(0);
       }
       else
       {
         filtersOut.writeInt(this.filters.size());
         filtersOut.writeUTF(createFilterHash(new ArrayList<String>(this.filters)));
         for (final String s : this.filters)
         {
-          filtersOut.writeUTF(s);
+          final byte[] b = s.getBytes("UTF-8");

[anton, 2017/02/16 06:17:24]

wouldn't it be better to have static final String CHARSET = "UTF-8" that is used
here and below (in serializeSubscription) ?

[diegocarloslima, 2017/02/22 22:43:53]

Acknowledged.

+          filtersOut.writeInt(b.length);
+          filtersOut.write(b);
         }
       }
     }
     finally
     {
       filtersOut.close();
     }
   }
 
   public void serializeSubscription(final File metaFile, final File filtersFile) throws IOException
@@ skipping 36 matching lines @@
       if (numFilters == 0)
       {
         this.filters = null;
       }
       else
       {
         this.filters = new HashSet<String>();
         final String filtersHash = in.readUTF();
         for (int i = 0; i < numFilters; i++)
         {
-          this.filters.add(in.readUTF());
+          final int length = in.readInt();
+          final byte[] b = new byte[length];
+          in.readFully(b);
+          this.filters.add(new String(b, "UTF-8"));
         }
         this.filtersValid = createFilterHash(new ArrayList<String>(this.filters)).equals(
             filtersHash);
         Log.d(TAG, "Filters valid: " + this.filtersValid);
       }
     }
     finally
     {
       in.close();
     }
@@ skipping 123 matching lines @@
     this.serializeMetaData(metaFile);
     if (filtersChanged)
     {
       this.serializeFilters(filtersFile);
       this.clearFilters();
     }
 
     return filtersChanged;
   }
 }