Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: new-options.js

Issue 29373674: Issue 3487 - Add links to the help tab (Closed)
Left Patch Set: Fixes according to Thomas comments Created Feb. 8, 2017, 1:12 p.m.
Right Patch Set: Fixed nit Created March 3, 2017, 10:20 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « new-options.html ('k') | skin/new-options.css » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 807 matching lines...) Expand 10 before | Expand all | Expand 10 after
818 filterTextbox.value = ""; 818 filterTextbox.value = "";
819 }); 819 });
820 } 820 }
821 E("custom-filters-add").addEventListener("submit", function(e) 821 E("custom-filters-add").addEventListener("submit", function(e)
822 { 822 {
823 e.preventDefault(); 823 e.preventDefault();
824 addCustomFilters(); 824 addCustomFilters();
825 }, false); 825 }, false);
826 var customFilterEditButtons = document.querySelectorAll("#custom-filters-edi t-wrapper button"); 826 var customFilterEditButtons = document.querySelectorAll("#custom-filters-edi t-wrapper button");
827 827
828 //Help tab 828 // Help tab
Thomas Greiner 2017/03/02 15:17:46 Detail: Usually, we put a space between `//` and t
829 getDocLink("faq", function(link) 829 getDocLink("faq", function(link)
830 { 830 {
831 E("link-faq").setAttribute("href", link); 831 E("link-faq").setAttribute("href", link);
832 }); 832 });
833 getDocLink("social_twitter", function(link) 833 getDocLink("social_twitter", function(link)
834 { 834 {
835 E("link-twitter").setAttribute("href", link); 835 E("link-twitter").setAttribute("href", link);
836 }); 836 });
837 getDocLink("social_facebook", function(link) 837 getDocLink("social_facebook", function(link)
838 { 838 {
(...skipping 477 matching lines...) Expand 10 before | Expand all | Expand 10 after
1316 ext.backgroundPage.sendMessage( 1316 ext.backgroundPage.sendMessage(
1317 { 1317 {
1318 type: "subscriptions.listen", 1318 type: "subscriptions.listen",
1319 filter: ["added", "disabled", "homepage", "lastDownload", "removed", 1319 filter: ["added", "disabled", "homepage", "lastDownload", "removed",
1320 "title", "downloadStatus", "downloading"] 1320 "title", "downloadStatus", "downloading"]
1321 }); 1321 });
1322 1322
1323 window.addEventListener("DOMContentLoaded", onDOMLoaded, false); 1323 window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
1324 window.addEventListener("hashchange", onHashChange, false); 1324 window.addEventListener("hashchange", onHashChange, false);
1325 })(); 1325 })();
LEFTRIGHT

Powered by Google App Engine
This is Rietveld