Issue 4865 - Make sure Identity.Name attribute is different for devbuilds for Edge

packagerEdge.py

Index: packagerEdge.py
===================================================================
--- a/packagerEdge.py
+++ b/packagerEdge.py
@@ -86,12 +86,17 @@
     params['version'] = pad_version(params['version'])
 
     metadata_id_suffix = 'release' if release_build else 'devbuild'

[Sebastian Noack, 2017/02/08 07:17:16]

Nit: Perhaps, call this variable just "metadata_suffix" now, that both options
that use this mechanism are some kind of ID is rather coincidental.

[Oleksandr, 2017/02/08 07:47:31]

Done.

-    metadata_id = 'extension_id_' + metadata_id_suffix
-    if metadata.has_option('general', metadata_id):
-        params['app_extension_id'] = metadata.get('general', metadata_id)
+    app_extension_id = 'extension_id_' + metadata_id_suffix
+    if metadata.has_option('general', app_extension_id):
+        params['app_extension_id'] = metadata.get('general', app_extension_id)
     else:
         params['app_extension_id'] = 'EdgeExtension'
 
+    app_id = 'app_id_' + metadata_id_suffix
+    if not metadata.has_option('general', app_id):
+        raise KeyError(app_id + ' key not found')

[Sebastian Noack, 2017/02/08 07:17:16]

Do we even need to specifically handle that case? Won't we get a similar error
anyway, when calling metadata.get('general', app_id) without prior check?

[Oleksandr, 2017/02/08 07:47:31]

Done.

+    params['app_id'] = metadata.get('general', app_id)
+
     translation = load_translation(files, defaultLocale)
     name_key = 'name' if release_build else 'name_devbuild'
     params['display_name'] = translation[name_key]['message']