Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: packagerEdge.py

Issue 29374642: Issue 4865 - Make sure Identity.Name attribute is different for devbuilds for Edge (Closed)
Patch Set: Rename a variable. Remove unnecessary conditional. Created Feb. 8, 2017, 7:45 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/metadata.edge » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packagerEdge.py
===================================================================
--- a/packagerEdge.py
+++ b/packagerEdge.py
@@ -85,13 +85,16 @@
params.update(metadata.items('general'))
params['version'] = pad_version(params['version'])
- metadata_id_suffix = 'release' if release_build else 'devbuild'
- metadata_id = 'extension_id_' + metadata_id_suffix
- if metadata.has_option('general', metadata_id):
- params['app_extension_id'] = metadata.get('general', metadata_id)
+ metadata_suffix = 'release' if release_build else 'devbuild'
+ app_extension_id = 'extension_id_' +metadata_suffix
+ if metadata.has_option('general', app_extension_id):
+ params['app_extension_id'] = metadata.get('general', app_extension_id)
else:
params['app_extension_id'] = 'EdgeExtension'
+ app_id = 'app_id_' + metadata_suffix
+ params['app_id'] = metadata.get('general', app_id)
+
translation = load_translation(files, defaultLocale)
name_key = 'name' if release_build else 'name_devbuild'
params['display_name'] = translation[name_key]['message']
« no previous file with comments | « no previous file | tests/metadata.edge » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld