Issue 4864 - Start using ESLint for adblockpluschrome

lib/compat.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 35 matching lines @@
   remove() {}
 };
 
 //
 // XPCOM emulation
 //
 
 function nsIFileURL() {}
 function nsIHttpChannel() {}
 
-let Components =
-{
+let Components = {
   interfaces:
   {
     nsIFile: {DIRECTORY_TYPE: 0},
     nsIFileURL,
     nsIHttpChannel,
     nsITimer: {TYPE_REPEATING_SLACK: 0},
     nsIInterfaceRequestor: null,
     nsIChannelEventSink: null
   },
   classes:
   {
     "@mozilla.org/timer;1":
     {
       createInstance() { return new FakeTimer(); }
     },
     "@mozilla.org/xmlextras/xmlhttprequest;1":
     {
       createInstance() { return new XMLHttpRequest(); }
     }
   },
   results: {},
   utils: {
-    import()
+    import(resource)
     {
+      let match = /^resource:\/\/gre\/modules\/(.+)\.jsm$/.exec(resource);
+      let resourceName = match && match[1];
+      if (resourceName && Cu.import.resources.has(resourceName))
+        return {[resourceName]: Cu.import.resources.get(resourceName)};

[Wladimir Palant, 2017/03/14 13:03:25]

As with the implementation in adblockplusui, this should throw for unknown
modules instead of returning undefined.

[kzar, 2017/03/15 04:57:47]

Done.

     },
     reportError(e)
     {
       console.error(e);
       console.trace();
     }
   },
   manager: null,
   ID() { return null; }
 };
 const Cc = Components.classes;
 const Ci = Components.interfaces;
 const Cr = Components.results;
 const Cu = Components.utils;
 
-let XPCOMUtils =
-{
+Cu.import.resources = new Map();
+
+Cu.import.resources.set("XPCOMUtils", {
   generateQI() {}
-};
+});
 
 //
 // Fake nsIFile implementation for our I/O
 //
 
 function FakeFile(path)
 {
   this.path = path;
 }
 FakeFile.prototype =
@@ skipping 18 matching lines @@
   {
     return {create() {}};
   },
   normalize() {}
 };
 
 //
 // Services.jsm module emulation
 //
 
-let Services =
-{
+Cu.import.resources.set("Services", {
   obs: {
     addObserver() {},
     removeObserver() {}
   },
   vc: {
     compare(v1, v2)
     {
       function parsePart(s)
       {
         if (!s)
@@ skipping 52 matching lines @@
       let parts2 = v2.split(".");
       for (let i = 0; i < Math.max(parts1.length, parts2.length); i++)
       {
         let result = compareParts(parsePart(parts1[i]), parsePart(parts2[i]));
         if (result)
           return result;
       }
       return 0;
     }
   }
-}
+});
 
 //
 // FileUtils.jsm module emulation
 //
 
-let FileUtils =
-{
+Cu.import.resources.set("FileUtils", {
   PERMS_DIRECTORY: 0
-};
+});
 
 function FakeTimer()
 {
 }
-FakeTimer.prototype =
-{
+FakeTimer.prototype = {
   delay: 0,
   callback: null,
   initWithCallback(callback, delay)
   {
     this.callback = callback;
     this.delay = delay;
     this.scheduleTimeout();
   },
   scheduleTimeout()
   {
     window.setTimeout(() =>
     {
       try
       {
         this.callback();
       }
-      catch(e)
+      catch (e)
       {
         Cu.reportError(e);
       }
       this.scheduleTimeout();
     }, this.delay);
   }
 };
 
 //
 // Add a channel property to XMLHttpRequest, Synchronizer needs it
 //
 
-XMLHttpRequest.prototype.channel =
-{
+XMLHttpRequest.prototype.channel = {
   status: -1,
   notificationCallbacks: {},
   loadFlags: 0,
   INHIBIT_CACHING: 0,
   VALIDATE_ALWAYS: 0,
   QueryInterface()
   {
     return this;
   }
 };