Issue 3768 - Check (and fix, if needed) multilocale builds

mozharness/base/vcs/vcsbase.py

 #!/usr/bin/env python
 # ***** BEGIN LICENSE BLOCK *****
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this file,
 # You can obtain one at http://mozilla.org/MPL/2.0/.
 # ***** END LICENSE BLOCK *****
 """Generic VCS support.
 """
 
 from copy import deepcopy
@@ skipping 57 matching lines @@
         vcs_class = VCS_DICT.get(vcs)
         if not vcs_class:
             self.error("Running vcs_checkout with kwargs %s" % str(kwargs))
             raise VCSException("No VCS set!")
         # need a better way to do this.
         if 'dest' not in kwargs:
             kwargs['dest'] = self.query_dest(kwargs)
         if 'vcs_share_base' not in kwargs:
             kwargs['vcs_share_base'] = c.get('%s_share_base' % vcs, c.get('vcs_share_base'))
         # Tries to checkout 'tag' if 'revision' is not defined
+        # See https://issues.adblockplus.org/ticket/3768
         if 'revision' not in kwargs:
             kwargs['revision'] = kwargs.get('tag')

[anton, 2017/02/15 11:00:05]

BTW can it be written as 'kwargs['tag']'?

[diegocarloslima, 2017/02/24 19:54:08]

The difference between using kwargs.get('tag') and kwargs['tag'], is that if the
dictionary doesn't contain a value for 'tag', using kwargs.get('tag') will
return None, while using kwargs['tag'] will throw an error

         vcs_obj = vcs_class(
             log_obj=self.log_obj,
             config=self.config,
             vcs_config=kwargs,
             script_obj=self,
         )
         return self.retry(
             self._get_revision,
             error_level=error_level,
             error_message="Automation Error: Can't checkout %s!" % kwargs['repo'],
@@ skipping 44 matching lines @@
 # This is here instead of mercurial.py because importing MercurialVCS into
 # vcsbase from mercurial, and importing VCSScript into mercurial from
 # vcsbase, was giving me issues.
 class MercurialScript(VCSScript):
     default_vcs = 'hg'
 
 
 # __main__ {{{1
 if __name__ == '__main__':
     pass