Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: mozharness/base/vcs/vcsbase.py

Issue 29374901: Issue 3768 - Check (and fix, if needed) multilocale builds (Closed)
Patch Set: Adding Issue reference Created Feb. 9, 2017, 9:28 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mozharness/base/vcs/vcsbase.py
===================================================================
--- a/mozharness/base/vcs/vcsbase.py
+++ b/mozharness/base/vcs/vcsbase.py
@@ -69,16 +69,20 @@ class VCSMixin(object):
if not vcs_class:
self.error("Running vcs_checkout with kwargs %s" % str(kwargs))
raise VCSException("No VCS set!")
# need a better way to do this.
if 'dest' not in kwargs:
kwargs['dest'] = self.query_dest(kwargs)
if 'vcs_share_base' not in kwargs:
kwargs['vcs_share_base'] = c.get('%s_share_base' % vcs, c.get('vcs_share_base'))
+ # Tries to checkout 'tag' if 'revision' is not defined
+ # See https://issues.adblockplus.org/ticket/3768
+ if 'revision' not in kwargs:
+ kwargs['revision'] = kwargs.get('tag')
anton 2017/02/15 11:00:05 BTW can it be written as 'kwargs['tag']'?
diegocarloslima 2017/02/24 19:54:08 The difference between using kwargs.get('tag') and
vcs_obj = vcs_class(
log_obj=self.log_obj,
config=self.config,
vcs_config=kwargs,
script_obj=self,
)
return self.retry(
self._get_revision,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld