Issue 4903 - Allow to specify file system root

libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java

Index: libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java
diff --git a/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java b/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java
index 0840fa3e182bd8896eae3fb937c1415504657cdb..2e37a01be44448cc35490cfd16ab7077a6c64377 100644
--- a/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java
+++ b/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java
@@ -42,6 +42,7 @@ public class AdblockHelper
   private static AdblockHelper _instance;
 
   private Context context;
+  private String basePath;
   private boolean developmentBuild;
   private String preferenceName;
   private AdblockEngine engine;
@@ -88,16 +89,29 @@ public class AdblockHelper
   /**
    * Init with context
    * @param context application context
+   * @param basePath file system root to store files
    * @param developmentBuild debug or release?
    * @param preferenceName Shared Preferences name
    */
-  public void init(Context context, boolean developmentBuild, String preferenceName)
+  public void init(Context context, String basePath, boolean developmentBuild, String preferenceName)
   {
     this.context = context.getApplicationContext();
+    this.basePath = basePath;
     this.developmentBuild = developmentBuild;
     this.preferenceName = preferenceName;
   }
 
+  /**
+   * Init with context
+   * @param context application context
+   * @param developmentBuild debug or release?
+   * @param preferenceName Shared Preferences name
+   */
+  public void init(Context context, boolean developmentBuild, String preferenceName)
+  {
+    init(context, context.getCacheDir().getAbsolutePath(), developmentBuild, preferenceName);

[diegocarloslima, 2017/03/13 13:58:11]

As you already pointed, it would be better to use getFilesDir() here, since the
cache can be cleared out by the system

[anton, 2017/03/14 04:15:26]

Well, i'd prefer to remove it at all or leave as-is because of
back-compatibility.
I don't see any reason for any app "default" directories (like getCacheDir() or
getFilesDir()) to be the only suitable and reasonable directory for the files so
i believe the user should make the decision himself.

[diegocarloslima, 2017/03/16 19:55:23]

I'm not against removing it, but if we decide to keep it, I would vote for
changing it, because we want to provide the best blocking experience possible,
and storing on cache directory which could be cleared by the system, can
compromise that

+  }
+
   private void createAdblock()
   {
     Log.d(TAG, "Creating adblock engine ...");
@@ -111,8 +125,7 @@ public class AdblockHelper
 
     engine = AdblockEngine.create(
       AdblockEngine.generateAppInfo(context, developmentBuild),
-      context.getCacheDir().getAbsolutePath(),
-      true); // `true` as we need element hiding
+      basePath, true); // `true` as we need element hiding
     Log.d(TAG, "AdblockHelper engine created");
 
     AdblockSettings settings = storage.load();