[adblockplus] Issue 4915 - Expose ext.i18n for background pages

ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 let {XPCOMUtils} = Cu.import("resource://gre/modules/XPCOMUtils.jsm", null);
 let {Services} = Cu.import("resource://gre/modules/Services.jsm", null);
 
-let {_EventTarget: EventTarget, i18n: i18n} = require("ext_common");

[Sebastian Noack, 2017/02/20 16:53:20]

You don't have to specify both destination and origin when they are the same
during destructuring.

  let {_EventTarget: EventTarget, i18n} = require("ext_common");

[wspee, 2017/03/01 14:54:08]

Done.

+let {_EventTarget: EventTarget, i18n} = require("ext_common");
 let {port} = require("messaging");
 
 exports.onMessage = new EventTarget(port);
 exports.i18n = i18n;
 
 function Page(windowID)
 {
   this._windowID = windowID;
 }
 Page.prototype = {
@@ skipping 38 matching lines @@
   {
     return this._map.delete(page._windowID);
   }
 };
 exports.PageMap = PageMap;
 
 exports.showOptions = function()
 {
   require("ui").UI.openFiltersDialog();
 };