Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: README.md

Issue 29377064: Issue 4944 - Make creation of FilterEngine asynchronous. (Closed)
Patch Set: rebase and address comments Created March 16, 2017, 3:47 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/AdblockPlus/FilterEngine.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: README.md
diff --git a/README.md b/README.md
index 05dcce1849ba86c144870c8d4d0fc04fe54bb585..6d5a658e91562818f43b3e07b929d509fb57e8c3 100644
--- a/README.md
+++ b/README.md
@@ -135,7 +135,10 @@ respectively.
With the `JsEngine` instance created, you can create a `FilterEngine` instance:
- FilterEngine filterEngine(jsEngine);
+ auto filterEngine = FilterEngine::Create(jsEngine);
+
+Please also pay attention to asynchronous version of factory method
+FilterEngine::CreateAsync and to optional creationParameters.
When initialised, `FilterEngine` will automatically select a suitable ad
blocking subscription based on `AppInfo::locale` and download the filters for
« no previous file with comments | « no previous file | include/AdblockPlus/FilterEngine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld