Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/WebRequest.cpp

Issue 29377064: Issue 4944 - Make creation of FilterEngine asynchronous. (Closed)
Patch Set: rebase and address comments Created March 16, 2017, 3:47 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/UpdateCheck.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/WebRequest.cpp
diff --git a/test/WebRequest.cpp b/test/WebRequest.cpp
index 09ff07e1609edb38be88ae8db0cd3f5ef3e46ad0..f2ba4bafbfe7ff67a140993b4b96abf23e548bdb 100644
--- a/test/WebRequest.cpp
+++ b/test/WebRequest.cpp
@@ -129,7 +129,7 @@ TEST_F(DefaultWebRequestTest, RealWebRequest)
TEST_F(DefaultWebRequestTest, XMLHttpRequest)
{
- AdblockPlus::FilterEngine filterEngine(jsEngine);
+ auto filterEngine = AdblockPlus::FilterEngine::Create(jsEngine);
ResetTestXHR(jsEngine);
jsEngine->Evaluate("\
@@ -159,7 +159,7 @@ TEST_F(DefaultWebRequestTest, DummyWebRequest)
TEST_F(DefaultWebRequestTest, XMLHttpRequest)
{
- AdblockPlus::FilterEngine filterEngine(jsEngine);
+ auto filterEngine = AdblockPlus::FilterEngine::Create(jsEngine);
ResetTestXHR(jsEngine);
jsEngine->Evaluate("\
@@ -210,7 +210,7 @@ TEST_F(XMLHttpRequestTest, RequestHeaderValidation)
auto catchLogSystem = CatchLogSystemPtr(new CatchLogSystem);
jsEngine->SetLogSystem(catchLogSystem);
- AdblockPlus::FilterEngine filterEngine(jsEngine);
+ auto filterEngine = AdblockPlus::FilterEngine::Create(jsEngine);
auto webRequest =
std::static_pointer_cast<MockWebRequest>(jsEngine->GetWebRequest());
« no previous file with comments | « test/UpdateCheck.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld