Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/IsAllowedConnectionCallbackImpl.java

Issue 29379647: Issue 4948 - add possibility to not send data depending on connection properties (Closed)
Left Patch Set: updated to 4931 code review patch set 3 and later Created March 21, 2017, 10:28 a.m.
Right Patch Set: updated dependency to binaries, updated comment for allowed connection type Created March 30, 2017, 2:12 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
Felix Dahlke 2017/03/24 07:37:25 2017 :)
anton 2017/03/24 09:43:11 Same here - is it ok to create separate task or ev
Felix Dahlke 2017/03/27 14:18:11 Acknowledged.
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 return false; 55 return false;
56 } 56 }
57 57
58 ConnectionType connectionType = ConnectionType.findByValue(connection); 58 ConnectionType connectionType = ConnectionType.findByValue(connection);
59 if (connectionType == null) 59 if (connectionType == null)
60 { 60 {
61 Log.e(TAG, "Unknown connection type: " + connection); 61 Log.e(TAG, "Unknown connection type: " + connection);
62 return false; 62 return false;
63 } 63 }
64 64
65 if (!connectionType.getChecker().isRequiredConnection(manager)) 65 if (!connectionType.isRequiredConnection(manager))
66 { 66 {
67 Log.w(TAG, "Current connection type is not allowed for subscription update s"); 67 Log.w(TAG, "Current connection type is not allowed for web requests");
68 return false; 68 return false;
69 } 69 }
70 70
71 return true; 71 return true;
72 } 72 }
73 } 73 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld