Issue 4127 - [emscripten] Convert subscription classes to C++ - Part 1

compiled/StringMap.h

+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-2017 eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
 #pragma once
 
 #include <cstddef>
 #include <cmath>
 #include <initializer_list>
 #include <memory>
 
 #include "String.h"
 #include "debug.h"
 
@@ skipping 200 matching lines @@
       return const_iterator(&mBuckets[0], &mBuckets[mBucketCount]);
     }
 
     const_iterator end() const
     {
       return const_iterator(&mBuckets[mBucketCount], &mBuckets[mBucketCount]);
     }
 
     size_type size() const
     {
-      return mBucketCount;
-    }
-
-    size_type length() const
-    {
       return mEntryCount;
     }
   };
 
   struct StringSetEntry
   {
     StringSetEntry() {}
     StringSetEntry(const String& key)
         : first(key)
     {
@@ skipping 74 matching lines @@
   friend class StringMap_internal::StringMapEntryReference<T>;
 
   explicit StringMap(size_type expectedEntries = 0)
       : super(expectedEntries)
   {
   }
 
   StringMap(std::initializer_list<entry_type> list)
       : super(list.size())
   {
-    for (auto it = list.begin(); it != list.end(); ++it)
-      super::insert(*it);
+    for (const auto& item : list)
+      super::insert(item);
   }
 
   ~StringMap()
   {
   }
 
   T& operator[](const String& key)
   {
     entry_type* entry = super::find_bucket(key);
     if (entry->first.is_invalid())
       entry = super::assign(entry, key);
     return entry->second;
   }
 
   const_reference find(const String& key) const
   {
     return super::find(key);
   }
 
   reference find(const String& key)
   {
     return reference(this, key, super::find_bucket(key));
   }
 };