Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: compiled/subscription/DownloadableSubscription.cpp

Issue 29384812: Issue 4127 - [emscripten] Convert subscription classes to C++ - Part 1 (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore
Left Patch Set: Switched to our own number conversion Created April 6, 2017, 3:25 p.m.
Right Patch Set: Addressed comments Created April 13, 2017, 1:02 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « compiled/subscription/DownloadableSubscription.h ('k') | compiled/subscription/Subscription.h » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 21 matching lines...) Expand all
32 result.append(u"fixedTitle=true\n"_str); 32 result.append(u"fixedTitle=true\n"_str);
33 if (!mHomepage.empty()) 33 if (!mHomepage.empty())
34 { 34 {
35 result.append(u"homepage="_str); 35 result.append(u"homepage="_str);
36 result.append(mHomepage); 36 result.append(mHomepage);
37 result.append(u'\n'); 37 result.append(u'\n');
38 } 38 }
39 if (mLastCheck) 39 if (mLastCheck)
40 { 40 {
41 result.append(u"lastCheck="_str); 41 result.append(u"lastCheck="_str);
42 result.append(static_cast<int64_t>(mLastCheck)); 42 result.append(mLastCheck);
43 result.append(u'\n'); 43 result.append(u'\n');
44 } 44 }
45 if (mHardExpiration) 45 if (mHardExpiration)
46 { 46 {
47 result.append(u"expires="_str); 47 result.append(u"expires="_str);
48 result.append(static_cast<int64_t>(mHardExpiration)); 48 result.append(mHardExpiration);
49 result.append(u'\n'); 49 result.append(u'\n');
50 } 50 }
51 if (mSoftExpiration) 51 if (mSoftExpiration)
52 { 52 {
53 result.append(u"softExpiration="_str); 53 result.append(u"softExpiration="_str);
54 result.append(static_cast<int64_t>(mSoftExpiration)); 54 result.append(mSoftExpiration);
55 result.append(u'\n'); 55 result.append(u'\n');
56 } 56 }
57 if (mLastDownload) 57 if (mLastDownload)
58 { 58 {
59 result.append(u"lastDownload="_str); 59 result.append(u"lastDownload="_str);
60 result.append(static_cast<int64_t>(mLastDownload)); 60 result.append(mLastDownload);
61 result.append(u'\n'); 61 result.append(u'\n');
62 } 62 }
63 if (!mDownloadStatus.empty()) 63 if (!mDownloadStatus.empty())
64 { 64 {
65 result.append(u"downloadStatus="_str); 65 result.append(u"downloadStatus="_str);
66 result.append(mDownloadStatus); 66 result.append(mDownloadStatus);
67 result.append(u'\n'); 67 result.append(u'\n');
68 } 68 }
69 if (mLastSuccess) 69 if (mLastSuccess)
70 { 70 {
71 result.append(u"lastSuccess="_str); 71 result.append(u"lastSuccess="_str);
72 result.append(static_cast<int64_t>(mLastSuccess)); 72 result.append(mLastSuccess);
73 result.append(u'\n'); 73 result.append(u'\n');
74 } 74 }
75 if (mErrorCount) 75 if (mErrorCount)
76 { 76 {
77 result.append(u"errors="_str); 77 result.append(u"errors="_str);
78 result.append(mErrorCount); 78 result.append(mErrorCount);
79 result.append(u'\n'); 79 result.append(u'\n');
80 } 80 }
81 if (mDataRevision) 81 if (mDataRevision)
82 { 82 {
83 result.append(u"version="_str); 83 result.append(u"version="_str);
84 result.append(static_cast<int64_t>(mDataRevision)); 84 result.append(mDataRevision);
85 result.append(u'\n'); 85 result.append(u'\n');
86 } 86 }
87 if (!mRequiredVersion.empty()) 87 if (!mRequiredVersion.empty())
88 { 88 {
89 result.append(u"requiredVersion="_str); 89 result.append(u"requiredVersion="_str);
90 result.append(mRequiredVersion); 90 result.append(mRequiredVersion);
91 result.append(u'\n'); 91 result.append(u'\n');
92 } 92 }
93 if (mDownloadCount) 93 if (mDownloadCount)
94 { 94 {
95 result.append(u"downloadCount="_str); 95 result.append(u"downloadCount="_str);
96 result.append(mDownloadCount); 96 result.append(mDownloadCount);
97 result.append(u'\n'); 97 result.append(u'\n');
98 } 98 }
99 return result; 99 return result;
100 } 100 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld