compiled/filter/Filter.h - Issue 29384812: Issue 4127 - [emscripten] Convert subscription classes to C++ - Part 1

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: compiled/filter/Filter.h

Issue 29384812: Issue 4127 - [emscripten] Convert subscription classes to C++ - Part 1 (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore

Patch Set: Removed unnecessary raw buffer Created April 10, 2017, 6:27 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: compiled/filter/Filter.h

===================================================================

--- a/compiled/filter/Filter.h

+++ b/compiled/filter/Filter.h

@@ -34,16 +34,17 @@ public:

UNKNOWN = 0,

INVALID = 1,

COMMENT = 2,

BLOCKING = 3,

WHITELIST = 4,

ELEMHIDE = 5,

ELEMHIDEEXCEPTION = 6,

ELEMHIDEEMULATION = 7,

+ MAXTYPE = 7

sergei 2017/04/12 12:04:33 I think that the name reflecting the number of val

Wladimir Palant 2017/04/13 13:04:40 Done.

};

explicit Filter(Type type, const String& text);

~Filter();

Type mType;

/* TODO

« compiled/bindings.ipp ('K') | « compiled/bindings.ipp ('k') | compiled/subscription/DownloadableSubscription.h » ('j') | compiled/subscription/Subscription.h » ('J')