Issue #5011 - Moves formmail template load to handler creation

sitescripts/formmail/test/test_formmail2.py

 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2016 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
@@ skipping 44 matching lines @@
         if data is None:
             response = urlopen(url)
         else:
             response = urlopen(url, urlencode(data))
         return response.code, response.read()
 
     yield response_for
     remove_wsgi_intercept()
 
 
+def test_form_handler_email_errors(form_config):
+    tmp_config = form_config
+    del tmp_config['url'].value
+    with pytest.raises(Exception) as error:
+        formmail2.make_handler('test', tmp_config)[1]
+    assert error.value.message == 'No URL configured for form handler: test'
+
+
+def test_form_handler_field_errors(form_config):
+    tmp_config = form_config
+    tmp_config['fields'] = {}
+    with pytest.raises(Exception) as error:
+        formmail2.make_handler('test', tmp_config)[1]
+    assert error.value.message == 'No fields configured for form handler: test'
+
+    del tmp_config['fields']
+    with pytest.raises(Exception) as error:
+        formmail2.make_handler('test', tmp_config)[1]
+    assert error.value.message == 'No fields configured for form handler: test'
+
+
+def test_form_handler_template_errors(form_config):
+    tmp_config = form_config
+    tmp_config['template'].value = 'no'
+    with pytest.raises(Exception) as error:
+        formmail2.make_handler('test', tmp_config)[1]
+    assert error.typename == 'TemplateNotFound'
+
+    del tmp_config['template'].value
+    with pytest.raises(Exception) as error:
+        formmail2.make_handler('test', tmp_config)[1]
+    assert error.value.message == ('No template configured for form handler'
+                                   ': test')
+    del tmp_config['template']
+    with pytest.raises(Exception) as error:
+        formmail2.make_handler('test', tmp_config)[1]
+    assert error.value.message == ('No template configured for form handler'
+                                   ': test')
+
+
 def test_config_parse(form_config):
     assert form_config['url'].value == 'test/apply/submit'
     assert form_config['fields']['email'].value == 'mandatory, email'
 
 
 def test_success(response_for, form_data, mocker):
     sm_mock = mocker.patch('sitescripts.formmail.web.formmail2.sendMail')
     assert response_for(form_data) == (200, '')
     assert sm_mock.call_count == 1
     params = sm_mock.call_args[0][1]['fields']
@@ skipping 26 matching lines @@
     del form_data['non_mandatory_email']
     assert response_for(form_data) == (200, '')
 
 
 def test_mandatory_fail_dflt_msg(response_for, form_data, mocker):
     mocker.patch('sitescripts.formmail.web.formmail2.sendMail')
     del form_data['mandatory']
     with pytest.raises(HTTPError) as error:
         response_for(form_data)
     assert error.value.read() == 'No mandatory entered'