Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: src/GlobalJsObject.cpp

Issue 29393589: Issue 5013 - Make more methods const.- introduced JsConstValuePtr and JsConstValueList- JsValue:… (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Created March 23, 2017, 6:12 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 void Run() 55 void Run()
56 { 56 {
57 Sleep(delay); 57 Sleep(delay);
58 58
59 function->Call(functionArguments); 59 function->Call(functionArguments);
60 } 60 }
61 61
62 private: 62 private:
63 JsValuePtr function; 63 JsValuePtr function;
64 int delay; 64 int delay;
65 JsValueList functionArguments; 65 JsConstValueList functionArguments;
66 }; 66 };
67 67
68 v8::Handle<v8::Value> SetTimeoutCallback(const v8::Arguments& arguments) 68 v8::Handle<v8::Value> SetTimeoutCallback(const v8::Arguments& arguments)
69 { 69 {
70 TimeoutThread* timeoutThread; 70 TimeoutThread* timeoutThread;
71 try 71 try
72 { 72 {
73 AdblockPlus::JsValueList converted = 73 AdblockPlus::JsValueList converted =
74 AdblockPlus::JsEngine::FromArguments(arguments) 74 AdblockPlus::JsEngine::FromArguments(arguments)
75 ->ConvertArguments(arguments); 75 ->ConvertArguments(arguments);
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 obj->SetProperty("_fileSystem", 113 obj->SetProperty("_fileSystem",
114 FileSystemJsObject::Setup(jsEngine, jsEngine->NewObject())); 114 FileSystemJsObject::Setup(jsEngine, jsEngine->NewObject()));
115 obj->SetProperty("_webRequest", 115 obj->SetProperty("_webRequest",
116 WebRequestJsObject::Setup(jsEngine, jsEngine->NewObject())); 116 WebRequestJsObject::Setup(jsEngine, jsEngine->NewObject()));
117 obj->SetProperty("console", 117 obj->SetProperty("console",
118 ConsoleJsObject::Setup(jsEngine, jsEngine->NewObject())); 118 ConsoleJsObject::Setup(jsEngine, jsEngine->NewObject()));
119 obj->SetProperty("_appInfo", 119 obj->SetProperty("_appInfo",
120 AppInfoJsObject::Setup(jsEngine, appInfo, jsEngine->NewObject())); 120 AppInfoJsObject::Setup(jsEngine, appInfo, jsEngine->NewObject()));
121 return obj; 121 return obj;
122 } 122 }
OLDNEW
« src/FilterEngine.cpp ('K') | « src/FilterEngine.cpp ('k') | src/JsValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld