Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: include/AdblockPlus/ITimer.h

Issue 29395640: Issue 3595 - Get rid of detached threads for setTimeout (Closed)
Patch Set: only rebase Created March 27, 2017, 2:44 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | include/AdblockPlus/JsEngine.h » ('j') | src/DefaultTimer.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 #ifndef ADBLOCK_PLUS_LOG_SYSTEM_H 18 #ifndef ADBLOCK_PLUS_TIMER_H
19 #define ADBLOCK_PLUS_LOG_SYSTEM_H 19 #define ADBLOCK_PLUS_TIMER_H
Oleksandr 2017/03/28 10:39:55 The diff in this file is weird. I assume your mere
sergei 2017/03/28 11:06:59 Yes, VCS is trying to be smarter and it detects it
20 20
21 #include <string> 21 #include <functional>
22 #include <chrono>
22 #include <memory> 23 #include <memory>
23 24
24 namespace AdblockPlus 25 namespace AdblockPlus
25 { 26 {
26 /** 27 /**
27 * Logging interface. 28 * Timer manager interface.
28 */ 29 */
29 class LogSystem 30 struct ITimer
30 { 31 {
31 public:
32 /** 32 /**
33 * Log level. 33 * Callback type invoked after elapsing of timer timeout.
34 */ 34 */
35 enum LogLevel {LOG_LEVEL_TRACE, LOG_LEVEL_LOG, LOG_LEVEL_INFO, LOG_LEVEL_WAR N, LOG_LEVEL_ERROR}; 35 typedef std::function<void()> TimerCallback;
36 36 virtual ~ITimer() {};
37 virtual ~LogSystem() {}
38 37
39 /** 38 /**
40 * Writes a log message. 39 * Sets a timer.
41 * @param logLevel Log level. 40 * @param timeout A timer callback will be called after that interval.
42 * @param message Log message. 41 * @param timeCallback The callback which is called after timeout.
43 * @param source Source of the message, e.g. file name and line.
44 * Ignored when empty.
45 */ 42 */
46 virtual void operator()(LogLevel logLevel, const std::string& message, 43 virtual void SetTimer(const std::chrono::milliseconds& timeout, const TimerC allback& timerCallback) = 0;
47 const std::string& source) = 0;
48 }; 44 };
49 45
50 /** 46 /**
51 * Shared smart pointer to a `LogSystem` instance. 47 * Unique smart pointer to an instance of `ITimer` implementation.
52 */ 48 */
53 typedef std::shared_ptr<LogSystem> LogSystemPtr; 49 typedef std::unique_ptr<ITimer> TimerPtr;
54 } 50 }
55 51
56 #endif 52 #endif
OLDNEW
« no previous file with comments | « no previous file | include/AdblockPlus/JsEngine.h » ('j') | src/DefaultTimer.h » ('J')

Powered by Google App Engine
This is Rietveld