Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: include/AdblockPlus/FilterEngine.h

Issue 29408747: Issue 5013 - Mark more method as const (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Isolate::Get() and JsEngine::GetIsolate() should be non-const Created April 11, 2017, 11:39 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | include/AdblockPlus/JsEngine.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 324 matching lines...) Expand 10 before | Expand all | Expand 10 after
335 * available even if subscription is not added yet. 335 * available even if subscription is not added yet.
336 * @return Returns URL of the Acceptable Ads. 336 * @return Returns URL of the Acceptable Ads.
337 */ 337 */
338 std::string GetAAUrl() const; 338 std::string GetAAUrl() const;
339 339
340 /** 340 /**
341 * Invokes the listener set via SetNotificationAvailableCallback() with the 341 * Invokes the listener set via SetNotificationAvailableCallback() with the
342 * next notification to be shown. 342 * next notification to be shown.
343 * @param url URL to match notifications to (optional). 343 * @param url URL to match notifications to (optional).
344 */ 344 */
345 void ShowNextNotification(const std::string& url = std::string()); 345 void ShowNextNotification(const std::string& url = std::string()) const;
346 346
347 /** 347 /**
348 * Sets the callback invoked when a notification should be shown. 348 * Sets the callback invoked when a notification should be shown.
349 * @param callback Callback to invoke. 349 * @param callback Callback to invoke.
350 */ 350 */
351 void SetShowNotificationCallback(const ShowNotificationCallback& value); 351 void SetShowNotificationCallback(const ShowNotificationCallback& value);
352 352
353 /** 353 /**
354 * Removes the callback invoked when a notification should be shown. 354 * Removes the callback invoked when a notification should be shown.
355 */ 355 */
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
527 JsEnginePtr jsEngine; 527 JsEnginePtr jsEngine;
528 bool firstRun; 528 bool firstRun;
529 int updateCheckId; 529 int updateCheckId;
530 static const std::map<ContentType, std::string> contentTypes; 530 static const std::map<ContentType, std::string> contentTypes;
531 531
532 explicit FilterEngine(const JsEnginePtr& jsEngine); 532 explicit FilterEngine(const JsEnginePtr& jsEngine);
533 533
534 FilterPtr CheckFilterMatch(const std::string& url, 534 FilterPtr CheckFilterMatch(const std::string& url,
535 ContentTypeMask contentTypeMask, 535 ContentTypeMask contentTypeMask,
536 const std::string& documentUrl) const; 536 const std::string& documentUrl) const;
537 void UpdateAvailable(UpdateAvailableCallback callback, JsValueList& params); 537 void UpdateAvailable(UpdateAvailableCallback callback, JsValueList& params) const;
538 void UpdateCheckDone(const std::string& eventName, 538 void UpdateCheckDone(const std::string& eventName,
539 UpdateCheckDoneCallback callback, JsValueList& params); 539 UpdateCheckDoneCallback callback, JsValueList& params);
540 void FilterChanged(FilterChangeCallback callback, JsValueList& params); 540 void FilterChanged(FilterChangeCallback callback, JsValueList& params) const ;
541 void ShowNotification(const ShowNotificationCallback& callback, 541 void ShowNotification(const ShowNotificationCallback& callback,
542 const JsValueList& params); 542 const JsValueList& params) const;
543 FilterPtr GetWhitelistingFilter(const std::string& url, 543 FilterPtr GetWhitelistingFilter(const std::string& url,
544 ContentTypeMask contentTypeMask, const std::string& documentUrl) const; 544 ContentTypeMask contentTypeMask, const std::string& documentUrl) const;
545 FilterPtr GetWhitelistingFilter(const std::string& url, 545 FilterPtr GetWhitelistingFilter(const std::string& url,
546 ContentTypeMask contentTypeMask, 546 ContentTypeMask contentTypeMask,
547 const std::vector<std::string>& documentUrls) const; 547 const std::vector<std::string>& documentUrls) const;
548 }; 548 };
549 } 549 }
550 550
551 #endif 551 #endif
OLDNEW
« no previous file with comments | « no previous file | include/AdblockPlus/JsEngine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld