Issue 5013 - Mark more method as const

src/FilterEngine.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 315 matching lines @@
 bool FilterEngine::IsAAEnabled() const
 {
   return jsEngine->Evaluate("API.isAASubscriptionEnabled()")->AsBool();
 }
 
 std::string FilterEngine::GetAAUrl() const
 {
   return GetPref("subscriptions_exceptionsurl")->AsString();
 }
 
-void FilterEngine::ShowNextNotification(const std::string& url)
+void FilterEngine::ShowNextNotification(const std::string& url) const
 {
   JsValuePtr func = jsEngine->Evaluate("API.showNextNotification");
   JsConstValueList params;
   if (!url.empty())
   {
     params.push_back(jsEngine->NewValue(url));
   }
   func->Call(params);
 }
 
@@ skipping 108 matching lines @@
       std::bind(&FilterEngine::UpdateAvailable, this, callback,
                 std::placeholders::_1));
 }
 
 void FilterEngine::RemoveUpdateAvailableCallback()
 {
   jsEngine->RemoveEventCallback("updateAvailable");
 }
 
 void FilterEngine::UpdateAvailable(
-    FilterEngine::UpdateAvailableCallback callback, JsValueList& params)
+    FilterEngine::UpdateAvailableCallback callback, JsValueList& params) const
 {
   if (params.size() >= 1 && !params[0]->IsNull())
     callback(params[0]->AsString());
 }
 
 void FilterEngine::ForceUpdateCheck(
     const FilterEngine::UpdateCheckDoneCallback& callback)
 {
   JsValuePtr func = jsEngine->Evaluate("API.forceUpdateCheck");
   JsConstValueList params;
@@ skipping 33 matching lines @@
 }
 
 std::unique_ptr<std::string> FilterEngine::GetAllowedConnectionType() const
 {
    auto prefValue = GetPref("allowed_connection_type");
    if (prefValue->AsString().empty())
      return nullptr;
    return std::unique_ptr<std::string>(new std::string(prefValue->AsString()));
 }
 
-void FilterEngine::FilterChanged(FilterEngine::FilterChangeCallback callback, JsValueList& params)
+void FilterEngine::FilterChanged(FilterEngine::FilterChangeCallback callback, JsValueList& params) const
 {
   std::string action(params.size() >= 1 && !params[0]->IsNull() ? params[0]->AsString() : "");
   JsValuePtr item(params.size() >= 2 ? params[1] : jsEngine->NewValue(false));
   callback(action, item);
 }
 
 void FilterEngine::ShowNotification(const ShowNotificationCallback& callback,
-                                         const JsValueList& params)
+                                         const JsValueList& params) const
 {
   if (params.size() < 1)
     return;
 
   if (!params[0]->IsObject())
   {
     return;
   }
   callback(NotificationPtr(new Notification(std::move(*params[0]))));
 }
@@ skipping 36 matching lines @@
     FilterPtr filter = GetWhitelistingFilter(currentUrl, contentTypeMask, parentUrl);
     if (filter)
     {
       return filter;
     }
     currentUrl = parentUrl;
   }
   while (urlIterator != documentUrls.end());
   return FilterPtr();
 }