Unified Diff: src/Utils.cpp
Issue 29409580:
Issue 5013 - Make parameter const ref when applicable. (Closed)
Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Remove an unecessary smart pointer.
Created April 11, 2017, 3:46 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« src/Utils.h ('k')
|
src/WebRequestJsObject.h » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: src/Utils.cpp |
| =================================================================== |
| --- a/src/Utils.cpp |
| +++ b/src/Utils.cpp |
| @@ -22,24 +22,24 @@ |
| #include <Windows.h> |
| #include <Shlwapi.h> |
| #endif |
| #include "Utils.h" |
| using namespace AdblockPlus; |
| -std::string Utils::Slurp(std::istream& stream) |
| +std::string Utils::Slurp(const std::istream& stream) |
| { |
| std::stringstream content; |
| content << stream.rdbuf(); |
| return content.str(); |
| } |
| -std::string Utils::FromV8String(v8::Handle<v8::Value> value) |
| +std::string Utils::FromV8String(const v8::Handle<v8::Value>& value) |
| { |
| v8::String::Utf8Value stringValue(value); |
| if (stringValue.length()) |
| return std::string(*stringValue, stringValue.length()); |
| else |
| return std::string(); |
| } |
« no previous file with comments
|
« src/Utils.h ('k')
|
src/WebRequestJsObject.h » ('j')
|
no next file with comments »
