Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: include/AdblockPlus/JsValue.h

Issue 29410664: Issue 5013 - Use const JsValue and pass reference where applicable (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Created April 12, 2017, 3:24 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 91
92 //@{ 92 //@{
93 /** 93 /**
94 * Sets a property value if this is an object (see `IsObject()`). 94 * Sets a property value if this is an object (see `IsObject()`).
95 * @param name Property name. 95 * @param name Property name.
96 * @param val Property value. 96 * @param val Property value.
97 */ 97 */
98 void SetProperty(const std::string& name, const std::string& val); 98 void SetProperty(const std::string& name, const std::string& val);
99 void SetProperty(const std::string& name, int64_t val); 99 void SetProperty(const std::string& name, int64_t val);
100 void SetProperty(const std::string& name, bool val); 100 void SetProperty(const std::string& name, bool val);
101 void SetProperty(const std::string& name, const JsValuePtr& value); 101 void SetProperty(const std::string& name, const JsValue& value);
102 inline void SetProperty(const std::string& name, const char* val) 102 inline void SetProperty(const std::string& name, const char* val)
103 { 103 {
104 SetProperty(name, std::string(val)); 104 SetProperty(name, std::string(val));
105 } 105 }
106 inline void SetProperty(const std::string& name, int val) 106 inline void SetProperty(const std::string& name, int val)
107 { 107 {
108 SetProperty(name, static_cast<int64_t>(val)); 108 SetProperty(name, static_cast<int64_t>(val));
109 } 109 }
110 //@} 110 //@}
111 111
(...skipping 17 matching lines...) Expand all
129 129
130 /** 130 /**
131 * Invokes the value as a function (see `IsFunction()`) with single 131 * Invokes the value as a function (see `IsFunction()`) with single
132 * parameter. 132 * parameter.
133 * @param arg A single required parameter. 133 * @param arg A single required parameter.
134 * @return Value returned by the function. 134 * @return Value returned by the function.
135 */ 135 */
136 JsValue Call(const JsValue& arg) const; 136 JsValue Call(const JsValue& arg) const;
137 137
138 v8::Local<v8::Value> UnwrapValue() const; 138 v8::Local<v8::Value> UnwrapValue() const;
139
140 /**
141 * Clone a this value to new one
142 * @return Value clone
sergei 2017/04/13 10:57:33 I think the comment should be different. It does n
hub 2017/04/13 12:06:24 ok.
143 */
144 JsValue Clone() const;
sergei 2017/04/13 10:57:33 Could you please change it to copy constructor but
139 protected: 145 protected:
140 JsEnginePtr jsEngine; 146 JsEnginePtr jsEngine;
141 private: 147 private:
142 JsValue(JsEnginePtr jsEngine, v8::Handle<v8::Value> value); 148 JsValue(JsEnginePtr jsEngine, v8::Handle<v8::Value> value);
143 void SetProperty(const std::string& name, v8::Handle<v8::Value> val); 149 void SetProperty(const std::string& name, v8::Handle<v8::Value> val);
144 // Parameter args is not const because a pointer to its internal arrays is 150 // Parameter args is not const because a pointer to its internal arrays is
145 // passed to v8::Function::Call but the latter does not expect a const point er. 151 // passed to v8::Function::Call but the latter does not expect a const point er.
146 JsValue Call(std::vector<v8::Handle<v8::Value>>& args, v8::Local<v8::Object> thisObj) const; 152 JsValue Call(std::vector<v8::Handle<v8::Value>>& args, v8::Local<v8::Object> thisObj) const;
147 153
148 std::unique_ptr<v8::Persistent<v8::Value>> value; 154 std::unique_ptr<v8::Persistent<v8::Value>> value;
149 }; 155 };
150 } 156 }
151 157
152 #endif 158 #endif
OLDNEW
« no previous file with comments | « include/AdblockPlus/JsEngine.h ('k') | src/AppInfoJsObject.h » ('j') | src/FilterEngine.cpp » ('J')

Powered by Google App Engine
This is Rietveld