Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: src/FileSystemJsObject.cpp

Issue 29410664: Issue 5013 - Use const JsValue and pass reference where applicable (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Left Patch Set: Created April 12, 2017, 3:24 p.m.
Right Patch Set: Fixed comment Created April 13, 2017, 3:45 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « src/ConsoleJsObject.cpp ('k') | src/FilterEngine.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 331 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 "_fileSystem.resolve requires 1 parameter")); 342 "_fileSystem.resolve requires 1 parameter"));
343 343
344 std::string resolved = jsEngine->GetFileSystem()->Resolve(converted[0]->AsSt ring()); 344 std::string resolved = jsEngine->GetFileSystem()->Resolve(converted[0]->AsSt ring());
345 345
346 return Utils::ToV8String(isolate, resolved); 346 return Utils::ToV8String(isolate, resolved);
347 } 347 }
348 348
349 } 349 }
350 350
351 351
352 JsValue& FileSystemJsObject::Setup(JsEngine& jsEngine, JsValue& obj) 352 JsValuePtr FileSystemJsObject::Setup(JsEngine& jsEngine, const JsValuePtr& obj)
353 { 353 {
354 obj.SetProperty("read", *jsEngine.NewCallback(::ReadCallback)); 354 obj->SetProperty("read", jsEngine.NewCallback(::ReadCallback));
355 obj.SetProperty("write", *jsEngine.NewCallback(::WriteCallback)); 355 obj->SetProperty("write", jsEngine.NewCallback(::WriteCallback));
356 obj.SetProperty("move", *jsEngine.NewCallback(::MoveCallback)); 356 obj->SetProperty("move", jsEngine.NewCallback(::MoveCallback));
357 obj.SetProperty("remove", *jsEngine.NewCallback(::RemoveCallback)); 357 obj->SetProperty("remove", jsEngine.NewCallback(::RemoveCallback));
358 obj.SetProperty("stat", *jsEngine.NewCallback(::StatCallback)); 358 obj->SetProperty("stat", jsEngine.NewCallback(::StatCallback));
359 obj.SetProperty("resolve", *jsEngine.NewCallback(::ResolveCallback)); 359 obj->SetProperty("resolve", jsEngine.NewCallback(::ResolveCallback));
360 return obj; 360 return obj;
361 } 361 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld