libadblockplus-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java - Issue 29411633: Issue 5136 - Add test for AndroidWebRequestResourceWrapper

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java

Issue 29411633: Issue 5136 - Add test for AndroidWebRequestResourceWrapper (Closed)

Patch Set: Created April 13, 2017, 1:40 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

« libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UtilsTest.java ('K') | « libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UtilsTest.java ('k') | libadblockplus-android/src/org/adblockplus/libadblockplus/android/Utils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: libadblockplus-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java

diff --git a/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java b/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java

index 4af10c8cfbabeee4ebfad686df38e9c8ae7dab60..4ec1d4a5bf415cfcb1f9f29a4f1f47db9275d8f5 100644

--- a/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java

+++ b/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java

@@ -112,7 +112,7 @@ public class AndroidWebRequestResourceWrapper extends WebRequest

public ServerResponse httpGET(String url, List<HeaderEntry> headers)

{

// since parameters may vary we need to ignore them

- String urlWithoutParams = url.substring(0, url.indexOf("?"));

+ String urlWithoutParams = Utils.getUrlWithoutParams(url);

anton 2017/04/13 13:46:50 actually extracting url without params isn't a dut

Integer resourceId = urlToResourceIdMap.get(urlWithoutParams);

if (resourceId != null)