Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: src/ConsoleJsObject.cpp

Issue 29418664: Issue 5162 - JsContext() takes a JsEngine& (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Created April 20, 2017, 7:53 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/FileSystemJsObject.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 11 matching lines...) Expand all
22 #include "ConsoleJsObject.h" 22 #include "ConsoleJsObject.h"
23 #include "JsContext.h" 23 #include "JsContext.h"
24 #include "Utils.h" 24 #include "Utils.h"
25 25
26 namespace 26 namespace
27 { 27 {
28 v8::Handle<v8::Value> DoLog(AdblockPlus::LogSystem::LogLevel logLevel, 28 v8::Handle<v8::Value> DoLog(AdblockPlus::LogSystem::LogLevel logLevel,
29 const v8::Arguments& arguments) 29 const v8::Arguments& arguments)
30 { 30 {
31 AdblockPlus::JsEnginePtr jsEngine = AdblockPlus::JsEngine::FromArguments(arg uments); 31 AdblockPlus::JsEnginePtr jsEngine = AdblockPlus::JsEngine::FromArguments(arg uments);
32 const AdblockPlus::JsContext context(jsEngine); 32 const AdblockPlus::JsContext context(*jsEngine);
33 AdblockPlus::JsValueList converted = jsEngine->ConvertArguments(arguments); 33 AdblockPlus::JsValueList converted = jsEngine->ConvertArguments(arguments);
34 34
35 std::stringstream message; 35 std::stringstream message;
36 for (size_t i = 0; i < converted.size(); i++) 36 for (size_t i = 0; i < converted.size(); i++)
37 { 37 {
38 if (i > 0) 38 if (i > 0)
39 message << " "; 39 message << " ";
40 message << converted[i].AsString(); 40 message << converted[i].AsString();
41 } 41 }
42 42
(...skipping 28 matching lines...) Expand all
71 } 71 }
72 72
73 v8::Handle<v8::Value> ErrorCallback(const v8::Arguments& arguments) 73 v8::Handle<v8::Value> ErrorCallback(const v8::Arguments& arguments)
74 { 74 {
75 return DoLog(AdblockPlus::LogSystem::LOG_LEVEL_ERROR, arguments); 75 return DoLog(AdblockPlus::LogSystem::LOG_LEVEL_ERROR, arguments);
76 } 76 }
77 77
78 v8::Handle<v8::Value> TraceCallback(const v8::Arguments& arguments) 78 v8::Handle<v8::Value> TraceCallback(const v8::Arguments& arguments)
79 { 79 {
80 AdblockPlus::JsEnginePtr jsEngine = AdblockPlus::JsEngine::FromArguments(arg uments); 80 AdblockPlus::JsEnginePtr jsEngine = AdblockPlus::JsEngine::FromArguments(arg uments);
81 const AdblockPlus::JsContext context(jsEngine); 81 const AdblockPlus::JsContext context(*jsEngine);
82 AdblockPlus::JsValueList converted = jsEngine->ConvertArguments(arguments); 82 AdblockPlus::JsValueList converted = jsEngine->ConvertArguments(arguments);
83 83
84 std::stringstream traceback; 84 std::stringstream traceback;
85 v8::Local<v8::StackTrace> frames = v8::StackTrace::CurrentStackTrace(100); 85 v8::Local<v8::StackTrace> frames = v8::StackTrace::CurrentStackTrace(100);
86 for (int i = 0, l = frames->GetFrameCount(); i < l; i++) 86 for (int i = 0, l = frames->GetFrameCount(); i < l; i++)
87 { 87 {
88 v8::Local<v8::StackFrame> frame = frames->GetFrame(i); 88 v8::Local<v8::StackFrame> frame = frames->GetFrame(i);
89 traceback << (i + 1) << ": "; 89 traceback << (i + 1) << ": ";
90 std::string name = AdblockPlus::Utils::FromV8String(frame->GetFunctionName ()); 90 std::string name = AdblockPlus::Utils::FromV8String(frame->GetFunctionName ());
91 if (name.size()) 91 if (name.size())
(...skipping 16 matching lines...) Expand all
108 AdblockPlus::JsEngine& jsEngine, AdblockPlus::JsValue& obj) 108 AdblockPlus::JsEngine& jsEngine, AdblockPlus::JsValue& obj)
109 { 109 {
110 obj.SetProperty("log", jsEngine.NewCallback(::LogCallback)); 110 obj.SetProperty("log", jsEngine.NewCallback(::LogCallback));
111 obj.SetProperty("debug", jsEngine.NewCallback(::DebugCallback)); 111 obj.SetProperty("debug", jsEngine.NewCallback(::DebugCallback));
112 obj.SetProperty("info", jsEngine.NewCallback(::InfoCallback)); 112 obj.SetProperty("info", jsEngine.NewCallback(::InfoCallback));
113 obj.SetProperty("warn", jsEngine.NewCallback(::WarnCallback)); 113 obj.SetProperty("warn", jsEngine.NewCallback(::WarnCallback));
114 obj.SetProperty("error", jsEngine.NewCallback(::ErrorCallback)); 114 obj.SetProperty("error", jsEngine.NewCallback(::ErrorCallback));
115 obj.SetProperty("trace", jsEngine.NewCallback(::TraceCallback)); 115 obj.SetProperty("trace", jsEngine.NewCallback(::TraceCallback));
116 return obj; 116 return obj;
117 } 117 }
OLDNEW
« no previous file with comments | « no previous file | src/FileSystemJsObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld