Issue 4231 - Fix unstable FilterEngineTest.testSetRemoveFilterChangeCallback

libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineGenericTest.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 package org.adblockplus.libadblockplus.tests;
 
+import org.adblockplus.libadblockplus.FileSystem;
 import org.adblockplus.libadblockplus.FilterEngine;
 import org.adblockplus.libadblockplus.LazyWebRequest;
 
 public abstract class FilterEngineGenericTest extends BaseJsTest
 {
   protected FilterEngine filterEngine;
 
+  private static final class PatternsIniStubFileSystem extends FileSystem
+  {
+    private static final String PATTERNS_INI = "patterns.ini";
+
+    private boolean patternsIniExists = true;
+
+    public boolean isPatternsIniExists()
+    {
+      return patternsIniExists;
+    }
+
+    public void setPatternsIniExists(boolean patternsIniExists)
+    {
+      this.patternsIniExists = patternsIniExists;
+    }
+
+    @Override
+    public String read(String path)
+    {
+      if (path.equals(PATTERNS_INI))
+      {
+        return "# Adblock Plus preferences\n[Subscription]\nurl=~fl~";
+      }
+      else if (path.equals("prefs.json"))
+      {
+        return "{}";
+      }
+      else
+      {
+        return "";
+      }
+    }
+
+    @Override
+    public void write(String path, String data)
+    {
+
+    }
+
+    @Override
+    public void move(String fromPath, String toPath)
+    {
+
+    }
+
+    @Override
+    public void remove(String path)
+    {
+
+    }
+
+    @Override
+    public FileSystem.StatResult stat(String path)
+    {
+      return path.equals(PATTERNS_INI)
+        ? new FileSystem.StatResult(patternsIniExists, false, true, 0)
+        : new FileSystem.StatResult(false, false, false, 0);
+    }
+
+    @Override
+    public String resolve(String path)
+    {
+      return path;
+    }
+  }
+
   @Override
   protected void setUp() throws Exception
   {
     super.setUp();
 
     jsEngine.setWebRequest(new LazyWebRequest());
     jsEngine.setDefaultLogSystem();
+    jsEngine.setFileSystem(new PatternsIniStubFileSystem());

[sergei, 2017/05/22 12:09:06]

Just for reference, I would expect that the proposed above implementation breaks
some tests. Previously there were no patterns.ini nor prefs.json files but now
there are and they are bare minimal what changes the behavior of core.

[anton, 2017/05/22 13:04:37]

Acknowledged.

 
     filterEngine = new FilterEngine(jsEngine);
   }
 }