Issue 4231 - Fix unstable FilterEngineTest.testSetRemoveFilterChangeCallback

libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineGenericTest.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 24 matching lines @@
     {
       return patternsIniExists;
     }
 
     public void setPatternsIniExists(boolean patternsIniExists)
     {
       this.patternsIniExists = patternsIniExists;
     }
 
     @Override
-    public String read(String path)
+    public byte[] read(String path)
     {
+      String result;
       if (path.equals(PATTERNS_INI))
       {
-        return "# Adblock Plus preferences\n[Subscription]\nurl=~fl~";
+        result = "# Adblock Plus preferences\n[Subscription]\nurl=~fl~";
       }
       else if (path.equals("prefs.json"))
       {
-        return "{}";
+        result = "{}";
       }
       else
       {
-        return "";
+        result = "";
       }
+      return result.getBytes();
     }
 
     @Override
-    public void write(String path, String data)
+    public void write(String path, byte[] data)
     {
 
     }
 
     @Override
     public void move(String fromPath, String toPath)
     {
 
     }
 
@@ skipping 18 matching lines @@
     }
   }
 
   @Override
   protected void setUp() throws Exception
   {
     super.setUp();
 
     jsEngine.setWebRequest(new LazyWebRequest());
     jsEngine.setDefaultLogSystem();
     jsEngine.setFileSystem(new PatternsIniStubFileSystem());

[sergei, 2017/05/22 12:09:06]

Just for reference, I would expect that the proposed above implementation breaks
some tests. Previously there were no patterns.ini nor prefs.json files but now
there are and they are bare minimal what changes the behavior of core.

[anton, 2017/05/22 13:04:37]

Acknowledged.

 
     filterEngine = new FilterEngine(jsEngine);
   }
 }