test/FilterEngine.cpp - Issue 29424663: Issue 5198 - workaround for race condition in tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: test/FilterEngine.cpp

Issue 29424663: Issue 5198 - workaround for race condition in tests (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git

Patch Set: Created April 28, 2017, 10:32 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: test/FilterEngine.cpp

diff --git a/test/FilterEngine.cpp b/test/FilterEngine.cpp

index 3244d42f4218e56fb63f2668f4503cb633e79cb9..8fd2659bb385dfa7c46b62a1e63fd70ceb11de6f 100644

--- a/test/FilterEngine.cpp

+++ b/test/FilterEngine.cpp

@@ -57,6 +57,10 @@ namespace

jsEngine->SetLogSystem(AdblockPlus::LogSystemPtr(new LogSystem));

filterEngine = AdblockPlus::FilterEngine::Create(jsEngine);

}

+ void TearDown() override

hub 2017/04/28 13:07:23 I would add a comment here to point at the actual

sergei 2017/04/28 13:14:33 Agree, I thought that one will later trace it usin

+ {

+ std::this_thread::sleep_for(std::chrono::milliseconds(100));

+ }

};

typedef FilterEngineTestGeneric<LazyFileSystem, AdblockPlus::DefaultLogSystem> FilterEngineTest;

« no previous file with comments | « no previous file | no next file » | no next file with comments »