Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: modules/discourse_docker/manifests/init.pp

Issue 29427603: Noissue - Configure discourse containers to use smtp on the host system Base URL: https://hg1/infrastructure
Patch Set: Created May 2, 2017, 9:23 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: modules/discourse_docker/manifests/init.pp
===================================================================
--- a/modules/discourse_docker/manifests/init.pp
+++ b/modules/discourse_docker/manifests/init.pp
@@ -52,6 +52,7 @@
$site_settings = hiera('discourse_docker::site_settings', {}),
$is_default = hiera('discourse_docker::is_default', false),
$admins = hiera('discourse_docker::admins', []),
+ $smtp_host = hiera('discourse_docker::smtp_host', undef),
mathias 2017/07/07 19:45:43 Since the template does not place any conditional
f.nicolaisen 2017/07/10 08:29:08 We could use 172.17.0.1 as configured in the hiera
mathias 2017/07/10 08:32:42 Why not use the formerly hard-coded DISCOURSE_SMTP
f.nicolaisen 2017/07/10 08:39:44 There is no smtp service on localhost. The contain
$google_oauth2_client_id = hiera('discourse_docker::google_oauth2_client_id', 'undef'),
$google_oauth2_client_secret = hiera('discourse_docker::google_oauth2_client_secret', 'undef'),
) {
« no previous file with comments | « no previous file | modules/discourse_docker/templates/app.yml.erb » ('j') | modules/private-stub/hiera/hosts/eyeoforum1.yaml » ('J')

Powered by Google App Engine
This is Rietveld