Issue 5183 - Provide async interface for FileSystem

src/FilterEngine.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 162 matching lines @@
 bool Subscription::IsAA() const
 {
   return jsEngine->Evaluate("API.isAASubscription").Call(*this).AsBool();
 }
 
 bool Subscription::operator==(const Subscription& subscription) const
 {
   return GetProperty("url").AsString() == subscription.GetProperty("url").AsString();
 }
 
-namespace
-{
-  class Sync

[sergei, 2017/07/05 10:03:21]

A minor thing, but do you mind to make this change (only concerning Sync) in
another commit?

[hub, 2017/07/06 12:21:52]

this require some patch surgery to make it worth it.

-  {
-  public:
-    Sync()
-      :initialized(false)
-    {
-
-    }
-    void Wait()
-    {
-      std::unique_lock<std::mutex> lock(mutex);
-      while (!initialized)
-        cv.wait(lock);
-    }
-    void Set()
-    {
-      {
-        std::unique_lock<std::mutex> lock(mutex);
-        initialized = true;
-      }
-      cv.notify_all();
-    }
-  private:
-    std::mutex mutex;
-    std::condition_variable cv;
-    bool initialized;
-  };
-}
-
 FilterEngine::FilterEngine(const JsEnginePtr& jsEngine)
   : jsEngine(jsEngine), firstRun(false), updateCheckId(0)
 {
 }
 
 void FilterEngine::CreateAsync(const JsEnginePtr& jsEngine,
   const FilterEngine::OnCreatedCallback& onCreated,
   const FilterEngine::CreationParameters& params)
 {
   FilterEnginePtr filterEngine(new FilterEngine(jsEngine));
@@ skipping 412 matching lines @@
     FilterPtr filter = GetWhitelistingFilter(currentUrl, contentTypeMask, parentUrl);
     if (filter)
     {
       return filter;
     }
     currentUrl = parentUrl;
   }
   while (urlIterator != documentUrls.end());
   return FilterPtr();
 }