Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: include/AdblockPlus/JsEngine.h

Issue 29449592: Issue 5183 - Provide async interface for FileSystem (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Left Patch Set: Rebased. Corrected most of the review issues. Created July 4, 2017, 7:57 p.m.
Right Patch Set: Rebase on master. Last changes. Created July 7, 2017, 1:36 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « include/AdblockPlus/IFileSystem.h ('k') | include/AdblockPlus/JsValue.h » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 314 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 325
326 explicit JsEngine(TimerPtr timer, FileSystemPtr fileSystem, WebRequestPtr we bRequest); 326 explicit JsEngine(TimerPtr timer, FileSystemPtr fileSystem, WebRequestPtr we bRequest);
327 327
328 JsValue GetGlobalObject(); 328 JsValue GetGlobalObject();
329 329
330 /// Isolate must be disposed only after disposing of all objects which are 330 /// Isolate must be disposed only after disposing of all objects which are
331 /// using it. 331 /// using it.
332 ScopedV8Isolate isolate; 332 ScopedV8Isolate isolate;
333 333
334 FileSystemPtr fileSystem; 334 FileSystemPtr fileSystem;
335 FileSystemSyncPtr fileSystemLegacy;
336 LogSystemPtr logSystem; 335 LogSystemPtr logSystem;
337 std::unique_ptr<v8::Global<v8::Context>> context; 336 std::unique_ptr<v8::Global<v8::Context>> context;
338 EventMap eventCallbacks; 337 EventMap eventCallbacks;
339 std::mutex eventCallbacksMutex; 338 std::mutex eventCallbacksMutex;
340 JsWeakValuesLists jsWeakValuesLists; 339 JsWeakValuesLists jsWeakValuesLists;
341 std::mutex jsWeakValuesListsMutex; 340 std::mutex jsWeakValuesListsMutex;
342 TimerPtr timer; 341 TimerPtr timer;
343 WebRequestPtr webRequest; 342 WebRequestPtr webRequest;
344 WebRequestSharedPtr webRequestLegacy; 343 WebRequestSharedPtr webRequestLegacy;
345 }; 344 };
346 } 345 }
347 346
348 #endif 347 #endif
LEFTRIGHT

Powered by Google App Engine
This is Rietveld