Issue 4907 - Update v8 to 5.7.278 in libadblockplus

libadblockplus.gypi

Index: libadblockplus.gypi
diff --git a/libadblockplus.gypi b/libadblockplus.gypi
new file mode 100644
index 0000000000000000000000000000000000000000..3c5b63dcdc704981d7c1ee81d3e49e20ef957a6c
--- /dev/null
+++ b/libadblockplus.gypi
@@ -0,0 +1,65 @@
+{
+  'includes': ['common.gypi'],
+  'conditions': [
+    ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris" \
+       or OS=="netbsd" or OS=="android"', {

[sergei, 2017/05/30 15:21:32]

I used the old list of OSes (see also common.gypi) but do we really need them?
We don't say anything about it in readme, our Makefile supports only linux,
android and mac, and I'm pretty sure that whoever is trying to compile it for
something else will face many other issues anyway.
I would leave linux and android here. What do you think?

+      'target_defaults': {
+        'cflags_cc': [ '-Wall', '-W', '-Wno-unused-parameter',
+                    '-Wnon-virtual-dtor', '-pedantic' ]
+      }
+    }],
+    ['OS=="win"', {
+      'target_defaults': {
+        'conditions': [
+          ['target_arch=="x64"', {
+            'msvs_configuration_platform': 'x64'
+          }]
+        ],
+        'msvs_configuration_attributes': {
+          'CharacterSet': '1',
+        },
+        'msbuild_toolset': 'v140_xp',

[Eric, 2017/05/30 17:31:41]

Why the XP version? Toolset 14.0 already won't work with ABP-IE as currently
configured, since its build is hard-coded to use toolset 12. We've talked about
dropping support for XP for while now. It looks like it's finally time.

And why require an out-dated version at all? It would seem we could at last just
stop specifying the toolset version entirely.

If ABP-IE needs a particular version, it would be better to have its gyp file
specify it. Then this gyp file could use that parameter. And since ABP-IE needs
new gyp files in order to use that version, just omit this entirely for now and
change it if or when ABP-IE ever upgrades.

[sergei, 2017/05/31 12:47:12]

Since there is no decision about dropping of _xp yet, I've added it here to be
sure that we still can compile, link for XP and tests successfully work.
Basically libadblockplus should not be aware about projects where it's used,
though it's unpractical sometimes.
Basically everything does work so far, so I think we may drop it here and make
required changes during updating of libadblockplus in IE.
Removed.

+        'defines': [
+          'WIN32',
+        ],
+        'link_settings': {
+          'libraries': ['-lDbgHelp'],
+        },
+      }
+    }],
+  ],
+
+  'target_defaults': {
+    'configurations': {
+      'Debug': {
+        'defines': [
+          'DEBUG'
+        ],
+        'msvs_settings': {
+          'VCCLCompilerTool': {
+            'conditions': [
+              ['component=="shared_library"', {
+                'RuntimeLibrary': '3',  #/MDd
+              }, {
+                'RuntimeLibrary': '1',  #/MTd
+              }
+            ]]
+          }
+        }
+      },
+      'Release': {
+        'msvs_settings': {
+          'VCCLCompilerTool': {
+            'conditions': [
+              ['component=="shared_library"', {
+                'RuntimeLibrary': '2',  #/MD
+              }, {
+                'RuntimeLibrary': '0',  #/MT
+              }
+            ]]
+          }
+        }
+      }
+    },
+  }
+}