Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: templates/chromeInfo.js.tmpl

Issue 29454678: Issue 5085 - Add edgeInfo.js template for edge specific builds (Closed)
Patch Set: remove chrome specific code from edge template, and edge specific from chrome Created June 7, 2017, 11:06 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | templates/edgeInfo.js.tmpl » ('j') | templates/edgeInfo.js.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: templates/chromeInfo.js.tmpl
===================================================================
--- a/templates/chromeInfo.js.tmpl
+++ b/templates/chromeInfo.js.tmpl
@@ -11,29 +11,19 @@
let regexp = /(\S+)\/(\S+)(?:\s*\(.*?\))?/g;
let match;
while (match = regexp.exec(navigator.userAgent))
{
let app = match[1];
let ver = match[2];
+ platformVersion = ver;
- if (app == "Chrome")
Sebastian Noack 2017/06/07 11:14:13 This part is still relevant on Chrome, only the ap
Jon Sonesen 2017/06/07 11:41:38 Acknowledged.
- {
- platformVersion = ver;
- }
- else if (app == "Edge")
- {
- platform = "edgehtml";
- platformVersion = ver;
- application = "edge";
- applicationVersion = "0";
- }
- else if (app != "Mozilla" && app != "AppleWebKit" && app != "Safari")
+ if (app != "Mozilla" && app != "AppleWebKit" && app != "Safari")
{
// For compatibility with legacy websites, Chrome's UA
// also includes a Mozilla, AppleWebKit and Safari token.
// Any further name/version pair indicates a fork.
application = app == "OPR" ? "opera" : app.toLowerCase();
applicationVersion = ver;
}
}
« no previous file with comments | « no previous file | templates/edgeInfo.js.tmpl » ('j') | templates/edgeInfo.js.tmpl » ('J')

Powered by Google App Engine
This is Rietveld